Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2295013002: Revert of Move text/selection update to the back of pipeline (Closed)

Created:
4 years, 3 months ago by dglazkov
Modified:
4 years, 3 months ago
Reviewers:
chrishtr, esprehn
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move text/selection update to the back of pipeline (patchset #3 id:40001 of https://codereview.chromium.org/2267933002/ ) Reason for revert: Need to do more testing/thinking. Original issue's description: > Move text/selection update to the back of pipeline > > Instead of forcing the spurious rendering pipeline flush to get an updated selection and text input information (for IME), do after the layout and style information had updated. > > BUG=640310 > > Committed: https://crrev.com/aa7d9e29b66032b9289769d2948c2b8a394ed4b0 > Cr-Commit-Position: refs/heads/master@{#415483} TBR=chrishtr@chromium.org,esprehn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640310 Committed: https://crrev.com/06854c5cf06608c8491ff2606eecf5760370fec7 Cr-Commit-Position: refs/heads/master@{#415509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/renderer/render_widget.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dglazkov
Created Revert of Move text/selection update to the back of pipeline
4 years, 3 months ago (2016-08-31 00:19:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295013002/1
4 years, 3 months ago (2016-08-31 00:19:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 00:20:33 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:23:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06854c5cf06608c8491ff2606eecf5760370fec7
Cr-Commit-Position: refs/heads/master@{#415509}

Powered by Google App Engine
This is Rietveld 408576698