Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4953)

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 22950007: Insufficient information on activation details should be handled correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/network/network_connection_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
index 69b0dc70562c02695b5ce251f9083c5b3da41aba..a2f1f292bbe84fc79f3748dbdbf0721cd59fe485 100644
--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
@@ -1779,6 +1779,14 @@ void PopulateCellularDetails(const NetworkState* cellular,
cellular->activation_state() == flimflam::kActivationStateActivating ||
cellular->IsConnectingState());
+ if (cellular->activation_state() == flimflam::kActivationStateUnknown) {
+ // Don't show any account management related buttons if the activation
+ // state is unknown and no payment portal URL is available.
+ std::string url;
stevenjb 2013/08/14 17:48:53 nit: support_url
armansito 2013/08/14 23:12:00 Done.
+ if (!dictionary->GetString(kTagSupportUrl, &url) || url.empty())
+ return;
+ }
+
if (cellular->activation_state() != flimflam::kActivationStateActivating &&
cellular->activation_state() != flimflam::kActivationStateActivated) {
dictionary->SetBoolean(kTagShowActivateButton, true);
« no previous file with comments | « no previous file | chromeos/network/network_connection_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698