Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3415)

Unified Diff: chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc

Issue 2294973002: Create MediaRouterActionController and MediaRouterUIService (Closed)
Patch Set: Modify BUILD.gn files, rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/media_router_action_controller.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc b/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6f25b895dd61e4b76709547829ab0b8f3b7a583f
--- /dev/null
+++ b/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
@@ -0,0 +1,195 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <memory>
+#include <string>
+
+#include "chrome/browser/media/router/mock_media_router.h"
+#include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
+#include "chrome/browser/ui/toolbar/media_router_action_controller.h"
+#include "chrome/browser/ui/webui/media_router/media_router_test.h"
+#include "chrome/common/pref_names.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+using extensions::ComponentMigrationHelper;
+
+class FakeComponentActionDelegate
+ : public ComponentMigrationHelper::ComponentActionDelegate {
+ public:
+ FakeComponentActionDelegate() {}
+ ~FakeComponentActionDelegate() {}
+
+ void AddComponentAction(const std::string& action_id) override {
+ EXPECT_EQ(action_id, ComponentToolbarActionsFactory::kMediaRouterActionId);
+ EXPECT_FALSE(HasComponentAction(
+ ComponentToolbarActionsFactory::kMediaRouterActionId));
+ has_media_router_action_ = true;
+ }
+
+ void RemoveComponentAction(const std::string& action_id) override {
+ EXPECT_EQ(action_id, ComponentToolbarActionsFactory::kMediaRouterActionId);
+ EXPECT_TRUE(HasComponentAction(
+ ComponentToolbarActionsFactory::kMediaRouterActionId));
+ has_media_router_action_ = false;
+ }
+
+ bool HasComponentAction(const std::string& action_id) const override {
+ EXPECT_EQ(action_id, ComponentToolbarActionsFactory::kMediaRouterActionId);
+ return has_media_router_action_;
+ }
+
+ private:
+ bool has_media_router_action_ = false;
+};
+
+class MediaRouterActionControllerUnitTest : public MediaRouterTest {
+ public:
+ MediaRouterActionControllerUnitTest()
+ : issue_(media_router::Issue(
+ "title notification",
+ "message notification",
+ media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),
+ std::vector<media_router::IssueAction>(),
+ "route_id",
+ media_router::Issue::NOTIFICATION,
+ false,
+ -1)),
+ source1_("fakeSource1"),
+ source2_("fakeSource2") {}
+
+ ~MediaRouterActionControllerUnitTest() override {}
+
+ // MediaRouterTest:
+ void SetUp() override {
+ MediaRouterTest::SetUp();
+
+ router_.reset(new media_router::MockMediaRouter());
+ component_action_delegate_.reset(new FakeComponentActionDelegate());
+ component_migration_helper_.reset(new ComponentMigrationHelper(
+ profile(), component_action_delegate_.get()));
+ controller_.reset(new MediaRouterActionController(
+ profile(), router_.get(), component_action_delegate_.get(),
+ component_migration_helper_.get()));
+
+ SetAlwaysShowActionPref(false);
+
+ local_display_route_list_.push_back(
+ media_router::MediaRoute("routeId1", source1_, "sinkId1", "description",
+ true, std::string(), true));
+ non_local_display_route_list_.push_back(
+ media_router::MediaRoute("routeId2", source1_, "sinkId2", "description",
+ false, std::string(), true));
+ non_local_display_route_list_.push_back(
+ media_router::MediaRoute("routeId3", source2_, "sinkId3", "description",
+ true, std::string(), false));
+ }
+
+ void TearDown() override {
+ controller_.reset();
+ component_migration_helper_.reset();
+ component_action_delegate_.reset();
+ router_.reset();
+ MediaRouterTest::TearDown();
+ }
+
+ bool ActionExists() {
+ return component_action_delegate_->HasComponentAction(
+ ComponentToolbarActionsFactory::kMediaRouterActionId);
+ }
+
+ void SetAlwaysShowActionPref(bool always_show) {
+ component_migration_helper_->SetComponentActionPref(
+ ComponentToolbarActionsFactory::kMediaRouterActionId, always_show);
+ }
+
+ MediaRouterActionController* controller() { return controller_.get(); }
+
+ const media_router::Issue* issue() { return &issue_; }
+ const std::vector<media_router::MediaRoute>& local_display_route_list()
+ const {
+ return local_display_route_list_;
+ }
+ const std::vector<media_router::MediaRoute>& non_local_display_route_list()
+ const {
+ return non_local_display_route_list_;
+ }
+ const std::vector<media_router::MediaRoute::Id>& empty_route_id_list() const {
+ return empty_route_id_list_;
+ }
+
+ private:
+ std::unique_ptr<MediaRouterActionController> controller_;
+ std::unique_ptr<media_router::MockMediaRouter> router_;
+ std::unique_ptr<FakeComponentActionDelegate> component_action_delegate_;
+ std::unique_ptr<ComponentMigrationHelper> component_migration_helper_;
+
+ const media_router::Issue issue_;
+
+ // Fake Sources, used for the Routes.
+ const media_router::MediaSource source1_;
+ const media_router::MediaSource source2_;
+
+ std::vector<media_router::MediaRoute> local_display_route_list_;
+ std::vector<media_router::MediaRoute> non_local_display_route_list_;
+ std::vector<media_router::MediaRoute::Id> empty_route_id_list_;
+
+ DISALLOW_COPY_AND_ASSIGN(MediaRouterActionControllerUnitTest);
+};
+
+TEST_F(MediaRouterActionControllerUnitTest, EphemeralIcon) {
+ EXPECT_FALSE(ActionExists());
+
+ // Creating a local route should show the action icon.
+ controller()->OnRoutesUpdated(local_display_route_list(),
+ empty_route_id_list());
+ EXPECT_TRUE(controller()->has_local_display_route_);
+ EXPECT_TRUE(ActionExists());
+ // Removing the local route should hide the icon.
+ controller()->OnRoutesUpdated(non_local_display_route_list(),
+ empty_route_id_list());
+ EXPECT_FALSE(controller()->has_local_display_route_);
+ EXPECT_FALSE(ActionExists());
+
+ // Creating an issue should show the action icon.
+ controller()->OnIssueUpdated(issue());
+ EXPECT_TRUE(controller()->has_issue_);
+ EXPECT_TRUE(ActionExists());
+ // Removing the issue should hide the icon.
+ controller()->OnIssueUpdated(nullptr);
+ EXPECT_FALSE(controller()->has_issue_);
+ EXPECT_FALSE(ActionExists());
+
+ controller()->OnIssueUpdated(issue());
+ controller()->OnRoutesUpdated(local_display_route_list(),
+ empty_route_id_list());
+ controller()->OnIssueUpdated(nullptr);
+ // When the issue disappears, the icon should remain visible if there's
+ // a local route.
+ EXPECT_TRUE(ActionExists());
+ controller()->OnRoutesUpdated(std::vector<media_router::MediaRoute>(),
+ empty_route_id_list());
+ EXPECT_FALSE(ActionExists());
+}
+
+TEST_F(MediaRouterActionControllerUnitTest, ObserveAlwaysShowPrefChange) {
+ EXPECT_FALSE(ActionExists());
+
+ SetAlwaysShowActionPref(true);
+ EXPECT_TRUE(ActionExists());
+
+ controller()->OnRoutesUpdated(local_display_route_list(),
+ empty_route_id_list());
+ SetAlwaysShowActionPref(false);
+ // Unchecking the option while having a local route shouldn't hide the icon.
+ EXPECT_TRUE(ActionExists());
+
+ SetAlwaysShowActionPref(true);
+ controller()->OnRoutesUpdated(non_local_display_route_list(),
+ empty_route_id_list());
+ // Removing the local route should not hide the icon.
+ EXPECT_TRUE(ActionExists());
+
+ SetAlwaysShowActionPref(false);
+ EXPECT_FALSE(ActionExists());
+}
« no previous file with comments | « chrome/browser/ui/toolbar/media_router_action_controller.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698