Create MediaRouterActionController and MediaRouterUIService

chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc

Index: chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
diff --git a/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc b/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d61b44e5d5aba9dcde54db297a491451b1d385d9
--- /dev/null
+++ b/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
@@ -0,0 +1,199 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/mock_media_router.h"
+#include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
+#include "chrome/browser/ui/toolbar/media_router_action_controller.h"
+#include "chrome/browser/ui/webui/media_router/media_router_test.h"
+#include "chrome/common/pref_names.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+using extensions::ComponentMigrationHelper;
+
+namespace {
+
+const char (&kMediaRouterActionId)[] =

[msw, 2016/09/16 22:22:26]

ditto: inline or comment

[takumif, 2016/09/17 00:24:30]

(repeated)
This is just to give it a shorter name. Is there a better way to do this? (By
inline, do you mean to use the full variable name everywhere?) This line also
doesn't pass cpplint, and I'm not sure if it's worth // NOLINT.

+    ComponentToolbarActionsFactory::kMediaRouterActionId;
+
+}
+
+class FakeComponentActionDelegate
+    : public ComponentMigrationHelper::ComponentActionDelegate {
+ public:
+  FakeComponentActionDelegate() : has_media_router_action_(false) {}
+  ~FakeComponentActionDelegate() {}
+
+  void AddComponentAction(const std::string& action_id) override {
+    if (action_id == kMediaRouterActionId) {
+      EXPECT_FALSE(HasComponentAction(kMediaRouterActionId));
+      has_media_router_action_ = true;
+    }
+  }
+
+  void RemoveComponentAction(const std::string& action_id) override {
+    if (action_id == kMediaRouterActionId) {
+      EXPECT_TRUE(HasComponentAction(kMediaRouterActionId));
+      has_media_router_action_ = false;
+    }
+  }
+
+  bool HasComponentAction(const std::string& action_id) const override {
+    if (action_id == kMediaRouterActionId)
+      return has_media_router_action_;
+    return false;

[msw, 2016/09/16 22:22:26]

optional nit: consider either:
  DCHECK_EQ(kMediaRouterActionId, action_id);
  return has_media_router_action_;
or perhaps:
  return action_id == kMediaRouterActionId && has_media_router_action_;

[takumif, 2016/09/17 00:24:30]

Done.

+  }
+
+ private:
+  bool has_media_router_action_;

[msw, 2016/09/16 22:22:26]

ditto optional nit: inline = false here; nix initializer list

[takumif, 2016/09/17 00:24:30]

Done.

+};
+
+class MediaRouterActionControllerUnitTest : public MediaRouterTest {
+ public:
+  MediaRouterActionControllerUnitTest()
+      : issue_(media_router::Issue(
+            "title notification",
+            "message notification",
+            media_router::IssueAction(media_router::IssueAction::TYPE_DISMISS),
+            std::vector<media_router::IssueAction>(),
+            "route_id",
+            media_router::Issue::NOTIFICATION,
+            false,
+            -1)),
+        source1_("fakeSource1"),
+        source2_("fakeSource2") {}
+
+  ~MediaRouterActionControllerUnitTest() override {}
+
+  // MediaRouterTest:
+  void SetUp() override {
+    MediaRouterTest::SetUp();
+
+    router_.reset(new media_router::MockMediaRouter());
+    component_action_delegate_.reset(new FakeComponentActionDelegate());
+    component_migration_helper_.reset(new ComponentMigrationHelper(
+        profile(), component_action_delegate_.get()));
+    controller_.reset(new MediaRouterActionController(
+        profile(), router_.get(), component_action_delegate_.get(),
+        component_migration_helper_.get()));
+
+    SetAlwaysShowActionPref(false);
+
+    local_display_route_list_.push_back(
+        media_router::MediaRoute("routeId1", source1_, "sinkId1",
+                                 "description", true, std::string(), true));
+    non_local_display_route_list_.push_back(
+        media_router::MediaRoute("routeId2", source1_, "sinkId2",
+                                 "description", false, std::string(), true));
+    non_local_display_route_list_.push_back(
+        media_router::MediaRoute("routeId3", source2_, "sinkId3",
+                                 "description", true, std::string(), false));
+  }
+
+  void TearDown() override {
+    controller_.reset();
+    component_migration_helper_.reset();
+    component_action_delegate_.reset();
+    router_.reset();
+    MediaRouterTest::TearDown();
+  }
+
+  bool ActionExists() {
+    return component_action_delegate_->HasComponentAction(kMediaRouterActionId);
+  }
+
+  void SetAlwaysShowActionPref(bool always_show) {
+    component_migration_helper_->SetComponentActionPref(kMediaRouterActionId,
+                                                        always_show);
+  }
+
+  MediaRouterActionController* controller() { return controller_.get(); }
+
+  const media_router::Issue* issue() { return &issue_; }
+  const std::vector<media_router::MediaRoute>& local_display_route_list()
+      const {
+    return local_display_route_list_;
+  }
+  const std::vector<media_router::MediaRoute>& non_local_display_route_list()
+      const {
+    return non_local_display_route_list_;
+  }
+  const std::vector<media_router::MediaRoute::Id>& empty_route_id_list() const {
+    return empty_route_id_list_;
+  }
+
+ private:
+  std::unique_ptr<MediaRouterActionController> controller_;
+  std::unique_ptr<media_router::MockMediaRouter> router_;
+  std::unique_ptr<FakeComponentActionDelegate> component_action_delegate_;
+  std::unique_ptr<ComponentMigrationHelper> component_migration_helper_;
+
+  const media_router::Issue issue_;
+
+  // Fake Sources, used for the Routes.
+  const media_router::MediaSource source1_;
+  const media_router::MediaSource source2_;
+
+  std::vector<media_router::MediaRoute> local_display_route_list_;
+  std::vector<media_router::MediaRoute> non_local_display_route_list_;
+  std::vector<media_router::MediaRoute::Id> empty_route_id_list_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaRouterActionControllerUnitTest);
+};
+
+TEST_F(MediaRouterActionControllerUnitTest, EphemeralIcon) {
+  EXPECT_FALSE(ActionExists());
+
+  // Creating a local route should show the action icon.
+  controller()->OnRoutesUpdated(local_display_route_list(),
+                                empty_route_id_list());
+  EXPECT_TRUE(controller()->has_local_display_route_);
+  EXPECT_TRUE(ActionExists());
+  // Removing the local route should hide the icon.
+  controller()->OnRoutesUpdated(non_local_display_route_list(),
+                                empty_route_id_list());
+  EXPECT_FALSE(controller()->has_local_display_route_);
+  EXPECT_FALSE(ActionExists());
+
+  // Creating an issue should show the action icon.
+  controller()->OnIssueUpdated(issue());
+  EXPECT_TRUE(controller()->has_issue_);
+  EXPECT_TRUE(ActionExists());
+  // Removing the issue should hide the icon.
+  controller()->OnIssueUpdated(nullptr);
+  EXPECT_FALSE(controller()->has_issue_);
+  EXPECT_FALSE(ActionExists());
+
+  controller()->OnIssueUpdated(issue());
+  controller()->OnRoutesUpdated(local_display_route_list(),
+                                empty_route_id_list());
+  controller()->OnIssueUpdated(nullptr);
+  // When the issue disappears, the icon should remain visible if there's
+  // a local route.
+  EXPECT_TRUE(ActionExists());
+  controller()->OnRoutesUpdated(std::vector<media_router::MediaRoute>(),
+                                empty_route_id_list());
+  EXPECT_FALSE(ActionExists());
+}
+
+TEST_F(MediaRouterActionControllerUnitTest, ObserveAlwaysShowPrefChange) {
+  EXPECT_FALSE(ActionExists());
+
+  SetAlwaysShowActionPref(true);
+  EXPECT_TRUE(ActionExists());
+
+  controller()->OnRoutesUpdated(
+      local_display_route_list(), empty_route_id_list());
+  SetAlwaysShowActionPref(false);
+  // Unchecking the option while having a local route shouldn't hide the icon.
+  EXPECT_TRUE(ActionExists());
+
+  SetAlwaysShowActionPref(true);
+  controller()->OnRoutesUpdated(
+      non_local_display_route_list(), empty_route_id_list());
+  // Removing the local route should not hide the icon.
+  EXPECT_TRUE(ActionExists());
+
+  SetAlwaysShowActionPref(false);
+  EXPECT_FALSE(ActionExists());
+}