Create MediaRouterActionController and MediaRouterUIService

chrome/browser/extensions/component_migration_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/component_migration_helper.h"
 
 #include "base/stl_util.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system_impl.h"
@@ skipping 121 matching lines @@
     return;
   if (base::ContainsKey(enabled_actions_, component_action_id)) {
     UnloadExtension(extension_id);
     SetComponentActionPref(component_action_id, true);
 
     if (!delegate_->HasComponentAction(component_action_id))
       delegate_->AddComponentAction(component_action_id);
   }
 }
 
+bool ComponentMigrationHelper::GetComponentActionPref(

[mark a. foltz, 2016/09/13 18:23:04]

- Please refactor @L80 to call this method.
- DCHECK() the success value from GetBoolean as is done above.

[takumif, 2016/09/14 04:00:51]

Done. DCHECKing here means component actions can only call this when the pref
exists for the action, and that should be okay (at least for MRA) since
MRUIService wouldn't be instantiated if MR is disabled, and OnFeatureDisabled()
(which removes prefs) only gets called when starting up ToolbarActionsModel.

+    const std::string& component_action_id) const {
+  const base::DictionaryValue* migration_pref = pref_service_->GetDictionary(
+      ::prefs::kToolbarMigratedComponentActionStatus);
+  bool component_action_pref = false;
+
+  migration_pref->GetBoolean(component_action_id, &component_action_pref);

[mark a. foltz, 2016/09/13 18:23:04]

What does this return if there is no pre-existing value for
|component_action_id| in |migration_pref|?

[takumif, 2016/09/14 04:00:51]

GetBoolean returns false and not touch |component_action_pref| in that case.
https://cs.chromium.org/chromium/src/base/values.cc?sq=package:chromium&rcl=1...

+  return component_action_pref;
+}
+
 void ComponentMigrationHelper::SetComponentActionPref(
     const std::string& component_action_id,
     bool enabled) {
   DictionaryPrefUpdate update(pref_service_,
                               ::prefs::kToolbarMigratedComponentActionStatus);
   update->SetBoolean(component_action_id, enabled);
 }
 
 bool ComponentMigrationHelper::IsExtensionInstalledAndEnabled(
     const ExtensionId& extension_id) const {
@@ skipping 27 matching lines @@
 std::string ComponentMigrationHelper::GetActionIdForExtensionId(
     const ExtensionId& extension_id) const {
   for (const auto& i : migrated_actions_) {
     if (i.second == extension_id)
       return i.first;
   }
   return "";
 }
 
 }  // namespace extensions