Submit Compositor Frame from OffscreenCanvas on main

third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef OffscreenCanvasFrameDispatcherImpl_h
+#define OffscreenCanvasFrameDispatcherImpl_h
+
+#include "base/memory/ref_counted.h"
+#include "cc/output/compositor_frame.h"

[Justin Novosad, 2016/09/02 19:11:15]

I think this include is only needed in the .cpp

[xlai (Olivia), 2016/09/02 20:10:07]

Done and also cleaned up other unnecessary include.

+#include "cc/surfaces/surface_id.h"
+#include "platform/PlatformExport.h"
+#include "platform/graphics/OffscreenCanvasFrameDispatcher.h"
+#include "public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom-blink.h"
+#include <memory>
+
+namespace blink {
+
+class PLATFORM_EXPORT OffscreenCanvasFrameDispatcherImpl final : public OffscreenCanvasFrameDispatcher {
+public:
+    explicit OffscreenCanvasFrameDispatcherImpl(uint32_t clientId, uint32_t localId, uint64_t nonce);
+    ~OffscreenCanvasFrameDispatcherImpl() override {}
+    const cc::SurfaceId& getSurfaceId() const { return m_surfaceId; }

[danakj, 2016/09/02 19:12:43]

group this separate from overrides

[xlai (Olivia), 2016/09/02 20:10:07]

Hmmm...I realize that I don't need this trivial getter at this moment. I delete
it now and will add it only when I find it useful.

+    void uploadImage(int width, int height) override;

[danakj, 2016/09/02 19:12:43]

Group overrides together and put a comment on them: //
OffscreenCanvasFrameDispatcher implementation.

[xlai (Olivia), 2016/09/02 20:10:07]

Done.

+
+private:
+    cc::SurfaceId m_surfaceId;
+    mojom::blink::OffscreenCanvasFrameReceiverPtr m_service;
+};
+
+} // namespace blink
+
+#endif // OffscreenCanvasFrameDispatcherImpl_h