Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2294953002: Revert of Remove ChromiumSvnPoller (Closed)

Created:
4 years, 3 months ago by Sergey Berezin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Remove ChromiumSvnPoller (patchset #1 id:1 of https://codereview.chromium.org/2284403002/ ) Reason for revert: This broke botmap_updater, because it is still used by at least one official master - see http://crbug.com/642448 (internal only). Original issue's description: > Remove ChromiumSvnPoller > > This is unused now. > > BUG=640212 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/a7625a98f986527265f39add33590853ddaaf761 TBR=tandrii@chromium.org,agable@chromium.org,maruel@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=640212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
A scripts/master/chromium_svn_poller.py View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Sergey Berezin
Created Revert of Remove ChromiumSvnPoller
4 years, 3 months ago (2016-08-30 21:29:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294953002/1
4 years, 3 months ago (2016-08-30 21:29:11 UTC) #3
M-A Ruel
Dropping a tear...
4 years, 3 months ago (2016-08-30 21:30:03 UTC) #4
tandrii(chromium)
LGTM, thanks!
4 years, 3 months ago (2016-08-30 21:30:19 UTC) #5
tandrii(chromium)
I can fix the internal master with one liner...
4 years, 3 months ago (2016-08-30 21:31:44 UTC) #7
Sergey Berezin
On 2016/08/30 at 21:31:44, tandrii wrote: > I can fix the internal master with one ...
4 years, 3 months ago (2016-08-30 21:33:29 UTC) #8
tandrii(chromium)
On 2016/08/30 21:31:44, tandrii(chromium) wrote: > I can fix the internal master with one liner... ...
4 years, 3 months ago (2016-08-30 21:33:44 UTC) #9
agable
On 2016/08/30 at 21:33:29, sergeyberezin wrote: > On 2016/08/30 at 21:31:44, tandrii wrote: > > ...
4 years, 3 months ago (2016-08-30 21:34:20 UTC) #10
agable
4 years, 3 months ago (2016-08-30 21:37:45 UTC) #11
Message was sent while issue was closed.
Woohoo, y'all are fast! Closing this, replaced by
https://chromereviews.googleplex.com/499777014

Powered by Google App Engine
This is Rietveld 408576698