Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2294943002: [Extensions] Remove SyncExtensionFunction (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove SyncExtensionFunction SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove SyncExtensionFunction. BUG=634140 Committed: https://crrev.com/f4c3ad865920504d33eadf8ff87e9719322a38b3 Cr-Commit-Position: refs/heads/master@{#415475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -52 lines) Patch
M extensions/browser/extension_function.h View 2 chunks +3 lines, -36 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
Antony, mind taking a look?
4 years, 3 months ago (2016-08-30 22:37:11 UTC) #7
asargent_no_longer_on_chrome
lgtm!
4 years, 3 months ago (2016-08-30 22:45:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294943002/1
4 years, 3 months ago (2016-08-30 22:49:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 22:55:26 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 22:57:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4c3ad865920504d33eadf8ff87e9719322a38b3
Cr-Commit-Position: refs/heads/master@{#415475}

Powered by Google App Engine
This is Rietveld 408576698