Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: components/offline_pages/background/offliner_policy.h

Issue 2294933003: [Offline Pages] Handle prerender FinalStatus UnsupportedScheme as a cancel rather than failure. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/offliner_policy.h
diff --git a/components/offline_pages/background/offliner_policy.h b/components/offline_pages/background/offliner_policy.h
index d640d2590a8cfae7411d8149ecbd3429f2e6c3b5..d3351c82991d002d3972c545f6947f96c575462d 100644
--- a/components/offline_pages/background/offliner_policy.h
+++ b/components/offline_pages/background/offliner_policy.h
@@ -6,7 +6,7 @@
#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_POLICY_H_
namespace {
-const int kMaxStartedTries = 5;
+const int kMaxStartedTries = 3;
dougarnett 2016/08/30 20:28:15 Per dimich request to reduce tries from 5 to 3. On
Pete Williamson 2016/08/30 20:42:47 This might be better as an unrelated changelist.
Dmitry Titov 2016/08/30 23:15:38 Note 5 or 3 are kinda theoretical w/o actual measu
dougarnett 2016/08/30 23:27:47 We don't yet have that UMA and agree we need it. I
dougarnett 2016/08/31 16:10:52 Per Pete's original request, reverting this change
const int kMaxCompletedTries = 1;
const int kBackgroundProcessingTimeBudgetSeconds = 170;
const int kSinglePageTimeLimitSeconds = 120;

Powered by Google App Engine
This is Rietveld 408576698