[Offline Pages] Handle prerender FinalStatus UnsupportedScheme as a cancel rather than failure.

chrome/browser/android/offline_pages/prerendering_loader.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/prerendering_loader.h"
 
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 139 matching lines @@
   // Loading has stopped so unless the Loader has already transistioned to the
   // idle state, clean up the previous request state, transition to the idle
   // state, and post callback.
   // Note: it is possible to receive some asynchronous stopped indication after
   // the request has completed/stopped via another path so the Loader may be
   // idle at this point.
 
   if (IsIdle())
     return;
 
-  if (adapter_->IsActive()) {
-    DVLOG(1) << "Load failed: " << adapter_->GetFinalStatus();
-    adapter_->DestroyActive();
-  }
   // Request status depends on whether we are still loading (failed) or
   // did load and then loading was stopped (cancel - from prerender stack).
   Offliner::RequestStatus request_status =
       IsLoaded() ? Offliner::RequestStatus::PRERENDERING_CANCELED
                  : Offliner::RequestStatus::PRERENDERING_FAILED;
-  // TODO(dougarnett): For failure, determine from final status if retry-able
-  // and report different failure statuses if retry-able or not.
+
+  if (adapter_->IsActive()) {
+    prerender::FinalStatus final_status = adapter_->GetFinalStatus();
+    DVLOG(1) << "Load failed: " << final_status;
+
+    // Loss of network connection can show up as unsupported scheme per
+    // a redirect to a special data URL is used to navigate to error page.
+    // We want to be able to retry these request so for now treat any
+    // unsupported scheme error as a cancel. See issue 642025.

[Pete Williamson, 2016/08/30 20:42:47]

If we are closing bug 642025 after this change, we need to open a new bug to fix
this hack the right way in the future.

[dougarnett, 2016/08/31 16:10:52]

Acknowledged.

+    // TODO(dougarnett): Create whitelist of final status codes that should
+    // not be considered failures (and define new RequestStatus code for them).
+    if (adapter_->GetFinalStatus() ==
+        prerender::FinalStatus::FINAL_STATUS_UNSUPPORTED_SCHEME) {
+      request_status = Offliner::RequestStatus::PRERENDERING_CANCELED;
+    }
+    adapter_->DestroyActive();
+  }
+
   snapshot_controller_.reset(nullptr);
   session_contents_.reset(nullptr);
   state_ = State::IDLE;
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(callback_, request_status, nullptr));
 }
 
 void PrerenderingLoader::CancelPrerender() {
   if (adapter_->IsActive()) {
     adapter_->DestroyActive();
   }
   snapshot_controller_.reset(nullptr);
   session_contents_.reset(nullptr);
   state_ = State::IDLE;
 }
 
 }  // namespace offline_pages