Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2294933002: Inline chrome/browser non-conditional sources into GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline chrome/browser non-conditional sources into GN build. This only does the non-conditional ones to make the patch a bit smaller and reduce the linkihood of merge conflicts. TBR=dpranke@chromium.org Committed: https://crrev.com/b55eb92f869300a8038b7da0b26b970b4e063160 Cr-Commit-Position: refs/heads/master@{#415479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1141 lines, -1240 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +1141 lines, -58 lines 0 comments Download
M chrome/chrome_browser.gypi View 17 chunks +0 lines, -1182 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
4 years, 3 months ago (2016-08-30 19:59:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294933002/1
4 years, 3 months ago (2016-08-30 20:00:09 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-30 20:01:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 23:02:38 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 23:04:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b55eb92f869300a8038b7da0b26b970b4e063160
Cr-Commit-Position: refs/heads/master@{#415479}

Powered by Google App Engine
This is Rietveld 408576698