Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2294913010: Revert of Reland [Telemetry] Convert long running user stories to the System Health format. (Closed)

Created:
4 years, 3 months ago by picksi1
Modified:
4 years, 3 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland [Telemetry] Convert long running user stories to the System Health format. (patchset #1 id:1 of https://codereview.chromium.org/2297783005/ ) Reason for revert: The long running gmail test enabled by the CL is failing and turning all the Android perf bots red. See crbug.com/643110/ Original issue's description: > Reland [Telemetry] Convert long running user stories to the System Health format. > > BUG=639315 > > Committed: https://crrev.com/1e7e98e048508e3c158244c409830f5a4ebc0630 > Cr-Commit-Position: refs/heads/master@{#415996} TBR=nednguyen@google.com,petrcermak@chromium.org,perezju@chromium.org,charliea@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639315, 643110 Committed: https://crrev.com/ff39c2e3c16c91a7beff4a959c918b344286b010 Cr-Commit-Position: refs/heads/master@{#416224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -110 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/page_sets/data/system_health_desktop.json View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/perf/page_sets/data/system_health_desktop_028.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 1 chunk +0 lines, -4 lines 0 comments Download
D tools/perf/page_sets/data/system_health_mobile_042.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/system_health/long_running_stories.py View 1 chunk +0 lines, -94 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
picksi1
Created Revert of Reland [Telemetry] Convert long running user stories to the System Health format.
4 years, 3 months ago (2016-09-02 09:20:51 UTC) #1
picksi1
Petr, please can you LGTM this revert. Randy has fixed the WPR issue but something ...
4 years, 3 months ago (2016-09-02 09:22:41 UTC) #2
petrcermak
I initially suggested only disabling the failing story, but different stories seem to be failing ...
4 years, 3 months ago (2016-09-02 09:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294913010/1
4 years, 3 months ago (2016-09-02 09:38:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 09:39:09 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 09:42:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff39c2e3c16c91a7beff4a959c918b344286b010
Cr-Commit-Position: refs/heads/master@{#416224}

Powered by Google App Engine
This is Rietveld 408576698