components/sync/core/password_metadata_filling.h - Issue 2294913009: Fill the un-encrypted metadata field in password specifics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync/core/password_metadata_filling.h

Issue 2294913009: Fill the un-encrypted metadata field in password specifics. (Closed)

Patch Set: check Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync/core/base_transaction.cc ('k') | components/sync/core/password_metadata_filling.cc » ('j') | components/sync/core/password_metadata_filling.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENETS_SYNC_CORE_PASSWORDS_METADAT_FILLING_H_
	Nicolas Zea 2016/09/23 23:10:37 Two typos (componenents and metadat) in this macro Two typos (componenents and metadat) in this macro. I'm surprised the presubmit didn't catch that though? Also, what about calling this file sync_features.h, and moving it to sync/base? We're likely to have other features in the future, so may as well centralize it. melandory 2016/10/04 10:13:12 Yep, weird. Show quoted text On 2016/09/23 23:10:37, Nicolas Zea wrote: > Two typos (componenents and metadat) in this macro. I'm surprised the presubmit > didn't catch that though? Yep, weird. Show quoted text > > Also, what about calling this file sync_features.h, and moving it to sync/base? > We're likely to have other features in the future, so may as well centralize it. Done.
	6 #define COMPONENETS_SYNC_CORE_PASSWORDS_METADAT_FILLING_H_

	7

	8 #include "base/feature_list.h"

	9

	10 namespace syncer {

	11

	12 extern const base::Feature kPasswordsMetadataFilling;
	Nicolas Zea 2016/09/23 23:10:37 I think it might be cleaner to just call this kFil I think it might be cleaner to just call this kFillPasswordMetadata melandory 2016/10/04 10:13:12 Done. Show quoted text On 2016/09/23 23:10:37, Nicolas Zea wrote: > I think it might be cleaner to just call this kFillPasswordMetadata Done.
	13

	14 } // namespace syncer

	15

	16 #endif // COMPONENETS_SYNC_CORE_PASSWORDS_METADAT_FILLING_H_

OLD	NEW