Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2294913006: [Interpreter] Enable allocation site mementos in CreateArrayLiterals. (Closed)
Patch Set: Fixed cctest.status Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 0afa8e2c4e95c803b4074d786f58f73e98316142..f19977a1e670db684ad2906046387005c093ed49 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -1882,8 +1882,7 @@ void BytecodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
void BytecodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
// Deep-copy the literal boilerplate.
builder()->CreateArrayLiteral(expr->constant_elements(),
- expr->literal_index(),
- expr->ComputeFlags(true));
mythria 2016/09/02 15:06:53 Ross, I think this is the only change that is requ
rmcilroy 2016/09/05 09:28:33 AST Graph Builder doesn't create mementos (presuma
Michael Starzinger 2016/09/05 12:23:04 Yes, correct. The reasoning was that only the unop
+ expr->literal_index(), expr->ComputeFlags());
Register index, literal;
// Evaluate all the non-constant subexpressions and store them into the
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698