src/globals.h - Issue 2294913004: [printing] Fix DCHECK failure when printing FAST_HOLEY_DOUBLE_ELEMENTS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 2294913004: [printing] Fix DCHECK failure when printing FAST_HOLEY_DOUBLE_ELEMENTS (Closed)

Patch Set: adding test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 6fc93d92db2707cc09b0d3ef6f27141513220aa6..5fa41bf9830ebe706e57ecb04badc495b2b83244 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -871,7 +871,7 @@ const uint32_t kHoleNanLower32 = 0xFFF7FFFF;

const uint64_t kHoleNanInt64 =

(static_cast<uint64_t>(kHoleNanUpper32) << 32) | kHoleNanLower32;

+const double kHoleNanDouble = bit_cast<double>(kHoleNanInt64);

// ES6 section 20.1.2.6 Number.MAX_SAFE_INTEGER

const double kMaxSafeInteger = 9007199254740991.0; // 2^53-1