Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2294893002: Remove .gypi sharing for Blink core + some tests (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
haraken, Dirk Pranke
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove .gypi sharing for Blink core + some tests Makes new "unit_tests" targets for core and modules, reference these from webkit_unit_tests and delete the associated .gypi and .gni machinery. Move all web file lists from .gypis to the GN build and remove web.gypi Committed: https://crrev.com/61a6b110f8d56b660fc52547e37819ef5aab60dc Cr-Commit-Position: refs/heads/master@{#415403}

Patch Set 1 #

Patch Set 2 : gn check fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -690 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +296 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -281 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 2 chunks +101 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 5 chunks +308 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/web/web.gypi View 1 chunk +0 lines, -304 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
brettw
4 years, 3 months ago (2016-08-30 18:14:11 UTC) #3
brettw
gn check fixes
4 years, 3 months ago (2016-08-30 18:20:14 UTC) #8
haraken
LGTM
4 years, 3 months ago (2016-08-30 19:40:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294893002/20001
4 years, 3 months ago (2016-08-30 20:00:51 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 20:05:36 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/61a6b110f8d56b660fc52547e37819ef5aab60dc Cr-Commit-Position: refs/heads/master@{#415403}
4 years, 3 months ago (2016-08-30 20:06:56 UTC) #18
Dirk Pranke
4 years, 3 months ago (2016-08-30 20:11:09 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698