Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2294873003: Revert of [polymer] - Sort series data before adding to legend. (Closed)

Created:
4 years, 3 months ago by aiolos (Not reviewing)
Modified:
4 years, 3 months ago
Reviewers:
shatch
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [polymer] - Sort series data before adding to legend. (patchset #1 id:1 of https://codereview.chromium.org/2233763003/ ) Reason for revert: This sorts the legend, but not the underlying graph data. It's leading to miss-matches between what people select and what graphs get shown. BUG=catapult:#2701 Original issue's description: > [polymer] - Sort series data before adding to legend. > > Demo deployed: https://clean-simonhatch-1dffaf54-dot-chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICghs24qQkM > > R=aiolos@chromium.org > BUG=catapult:#2558 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/76ba893246e3a5331793b91278d0aeb3b3c16313 TBR=simonhatch@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#2558 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dccd40a985c9805dd43c035dd6c045e59dbd5aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M dashboard/dashboard/elements/chart-container.html View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
aiolos (Not reviewing)
Created Revert of [polymer] - Sort series data before adding to legend.
4 years, 3 months ago (2016-08-30 23:34:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294873003/1
4 years, 3 months ago (2016-08-30 23:34:28 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:04:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698