Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2294853004: Remove fprintf() from core/editing/. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fprintf() from core/editing/. Use LOG(INFO) instead. Committed: https://crrev.com/81d654fb5d6cab87bd8611114cb41562e2b21d45 Cr-Commit-Position: refs/heads/master@{#415580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-31 06:36:00 UTC) #5
yosin_UTC9
lgtm Thanks for cleanup!
4 years, 3 months ago (2016-08-31 06:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294853004/1
4 years, 3 months ago (2016-08-31 07:45:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 07:50:33 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 07:52:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81d654fb5d6cab87bd8611114cb41562e2b21d45
Cr-Commit-Position: refs/heads/master@{#415580}

Powered by Google App Engine
This is Rietveld 408576698