Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2294853003: Break dependency between ash::DisplayManager and ash::ScreenAsh (Closed)

Created:
4 years, 3 months ago by rjkroege
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break dependency between ash::DisplayManager and ash::ScreenAsh As part of preparing ash::DisplayManager for relocation to ui::display, remove its dependency on ash::ScreenAsh and instead inject the Screen implementation at the time of construction. Eventually, ash::DisplayManager will be in ui::display and existing ash (via ash::ScreenAsh) or mus (via ws::display::PlatformScreen) will inject an appropriate display::Screen implementation. BUG=581462 Committed: https://crrev.com/2c930540bac9acebd1419e87e3a61c1fa5d59a6d Cr-Commit-Position: refs/heads/master@{#416792}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -73 lines) Patch
M ash/display/display_manager.h View 8 chunks +17 lines, -6 lines 0 comments Download
M ash/display/display_manager.cc View 12 chunks +35 lines, -27 lines 0 comments Download
M ash/display/screen_ash.h View 2 chunks +9 lines, -17 lines 0 comments Download
M ash/display/screen_ash.cc View 3 chunks +25 lines, -21 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
rjkroege
ptal
4 years, 3 months ago (2016-08-31 01:52:20 UTC) #2
oshima
lgtm
4 years, 3 months ago (2016-08-31 22:53:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294853003/20001
4 years, 3 months ago (2016-09-06 23:25:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 00:22:03 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:24:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c930540bac9acebd1419e87e3a61c1fa5d59a6d
Cr-Commit-Position: refs/heads/master@{#416792}

Powered by Google App Engine
This is Rietveld 408576698