WebBlobInfo plumbing for WebIDBDatabaseImpl::put.

WebBlobInfo plumbing for WebIDBDatabaseImpl::put.
Depends on https://codereview.chromium.org/227693008/.

BUG=108012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262857

[ericu, 2014-04-09 00:11:16]

Sorry about the try noise; I forgot this CL depended on one which hasn't landed
yet.

[cmumford, 2014-04-09 17:29:48]

lgtm

https://codereview.chromium.org/229483003/diff/20001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher.cc (right):

https://codereview.chromium.org/229483003/diff/20001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher.cc:328: const
blink::WebVector<WebBlobInfo>& webBlobInfo,
The other parameters are snake_case, but this is not. Which is right?

[ericu, 2014-04-09 18:10:05]

https://codereview.chromium.org/229483003/diff/20001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher.cc (right):

https://codereview.chromium.org/229483003/diff/20001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher.cc:328: const
blink::WebVector<WebBlobInfo>& webBlobInfo,
On 2014/04/09 17:29:48, cmumford wrote:
> The other parameters are snake_case, but this is not. Which is right?

Done.

[jsbell, 2014-04-09 20:11:08]

lgtm with nits/suggestions

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher.cc (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher.cc:371:
params.blob_or_file_info[i].is_file = info.isFile();
Would a local reference to params.blob_or_file_info[i] make this more readable?

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher.h (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher.h:135: const
blink::WebVector<blink::WebBlobInfo>& webBlobInfo,
Fix case of this parameter as well?

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher_unittest.cc (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher_unittest.cc:36: virtual void
onError(const WebIDBDatabaseError&) OVERRIDE {
IIRC, in content/ we don't typically mark overrides of blink public API methods
with OVERRIDE, to ease in removing them.

(Although our typical 3-sided patch dance for IDB removes old blink APIs last,
so it's not an issue).

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher_unittest.cc:78: const
WebVector<WebBlobInfo> webBlobInfo;
Should be snake_case here (and below)

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/webidbdatabase_impl.cc (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/webidbdatabase_impl.cc:139: const
blink::WebVector<WebBlobInfo>& webBlobInfo,
Ugh. Case should match the header, which matches blink names, which would be
camelCase. But the other params are snake_case.

Should probably be snake_case to match.

[ericu, 2014-04-09 21:14:47]

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher.cc (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher.cc:371:
params.blob_or_file_info[i].is_file = info.isFile();
On 2014/04/09 20:11:08, jsbell wrote:
> Would a local reference to params.blob_or_file_info[i] make this more
readable?

Yeah, a little.  Done.

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher.h (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher.h:135: const
blink::WebVector<blink::WebBlobInfo>& webBlobInfo,
On 2014/04/09 20:11:08, jsbell wrote:
> Fix case of this parameter as well?

Done.

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/indexed_db_dispatcher_unittest.cc (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher_unittest.cc:36: virtual void
onError(const WebIDBDatabaseError&) OVERRIDE {
On 2014/04/09 20:11:08, jsbell wrote:
> IIRC, in content/ we don't typically mark overrides of blink public API
methods
> with OVERRIDE, to ease in removing them.
> 
> (Although our typical 3-sided patch dance for IDB removes old blink APIs last,
> so it's not an issue).

Gotcha; reverted.

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/indexed_db_dispatcher_unittest.cc:78: const
WebVector<WebBlobInfo> webBlobInfo;
On 2014/04/09 20:11:08, jsbell wrote:
> Should be snake_case here (and below)

Done.

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
File content/child/indexed_db/webidbdatabase_impl.cc (right):

https://codereview.chromium.org/229483003/diff/60001/content/child/indexed_db...
content/child/indexed_db/webidbdatabase_impl.cc:139: const
blink::WebVector<WebBlobInfo>& webBlobInfo,
On 2014/04/09 20:11:08, jsbell wrote:
> Ugh. Case should match the header, which matches blink names, which would be
> camelCase. But the other params are snake_case.
> 
> Should probably be snake_case to match.

I think the existing code's a reasonable compromise; the header's blink style,
the implementation is chromium style.  I'll match that.

[ericu, 2014-04-09 21:16:02]

The CQ bit was checked by ericu@chromium.org

[commit-bot: I haz the power, 2014-04-09 21:16:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericu@chromium.org/229483003/80001

[commit-bot: I haz the power, 2014-04-09 23:40:09]

Change committed as 262857