Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: build/config/android/config.gni

Issue 2294823002: Remove lint variables from SDK version and path. (Closed)
Patch Set: Address jbudorick comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains common system config stuff for the Android build. 5 # This file contains common system config stuff for the Android build.
6 6
7 if (is_android) { 7 if (is_android) {
8 assert(rebase_path("//", root_build_dir) == "../../", 8 assert(rebase_path("//", root_build_dir) == "../../",
9 "Android output directory must be nested 2 levels within src/ (" + 9 "Android output directory must be nested 2 levels within src/ (" +
10 "e.g.: out-gn/Debug). http://crbug.com/412935") 10 "e.g.: out-gn/Debug). http://crbug.com/412935")
(...skipping 14 matching lines...) Expand all
25 } 25 }
26 26
27 if (!defined(default_android_ndk_root)) { 27 if (!defined(default_android_ndk_root)) {
28 default_android_ndk_major_version = "10" 28 default_android_ndk_major_version = "10"
29 default_android_ndk_root = "//third_party/android_tools/ndk" 29 default_android_ndk_root = "//third_party/android_tools/ndk"
30 default_android_ndk_version = "r10e" 30 default_android_ndk_version = "r10e"
31 } else { 31 } else {
32 assert(defined(default_android_ndk_version)) 32 assert(defined(default_android_ndk_version))
33 } 33 }
34 34
35 # The same version of lint should be used for building all targets, 35 if (!defined(default_android_sdk_root)) {
36 # and these args ensure that the upstream version of lint is used for 36 default_android_sdk_root = "//third_party/android_tools/sdk"
37 # both upstream and downstream targets. 37 default_android_sdk_version = "23"
38 lint_android_sdk_root = "//third_party/android_tools/sdk" 38 default_android_sdk_build_tools_version = "23.0.1"
39 lint_android_sdk_version = "23" 39 }
40 40
41 if (!defined(default_android_sdk_root)) { 41 if (!defined(default_lint_android_sdk_root)) {
42 # Reuse the lint variables to ensure that the lint version gets updated 42 default_lint_android_sdk_root = default_android_sdk_root
43 # when the upstream SDK version is updated. 43 default_lint_android_sdk_version = default_android_sdk_version
44 default_android_sdk_root = lint_android_sdk_root
45 default_android_sdk_version = lint_android_sdk_version
46 default_android_sdk_build_tools_version = "23.0.1"
47 } 44 }
48 45
49 if (!defined(default_android_keystore_path)) { 46 if (!defined(default_android_keystore_path)) {
50 default_android_keystore_path = 47 default_android_keystore_path =
51 "//build/android/ant/chromium-debug.keystore" 48 "//build/android/ant/chromium-debug.keystore"
52 default_android_keystore_name = "chromiumdebugkey" 49 default_android_keystore_name = "chromiumdebugkey"
53 default_android_keystore_password = "chromium" 50 default_android_keystore_password = "chromium"
54 } 51 }
55 52
56 if (!defined(google_play_services_library)) { 53 if (!defined(google_play_services_library)) {
(...skipping 14 matching lines...) Expand all
71 68
72 declare_args() { 69 declare_args() {
73 android_ndk_major_version = default_android_ndk_major_version 70 android_ndk_major_version = default_android_ndk_major_version
74 android_ndk_root = default_android_ndk_root 71 android_ndk_root = default_android_ndk_root
75 android_ndk_version = default_android_ndk_version 72 android_ndk_version = default_android_ndk_version
76 73
77 android_sdk_root = default_android_sdk_root 74 android_sdk_root = default_android_sdk_root
78 android_sdk_version = default_android_sdk_version 75 android_sdk_version = default_android_sdk_version
79 android_sdk_build_tools_version = default_android_sdk_build_tools_version 76 android_sdk_build_tools_version = default_android_sdk_build_tools_version
80 77
78 lint_android_sdk_root = default_lint_android_sdk_root
79 lint_android_sdk_version = default_lint_android_sdk_version
80
81 # Libc++ library directory. Override to use a custom libc++ binary. 81 # Libc++ library directory. Override to use a custom libc++ binary.
82 android_libcpp_lib_dir = "" 82 android_libcpp_lib_dir = ""
83 83
84 # Android versionCode for android_apk()s that don't expclitly set one. 84 # Android versionCode for android_apk()s that don't expclitly set one.
85 android_default_version_code = "1" 85 android_default_version_code = "1"
86 86
87 # Android versionName for android_apk()s that don't expclitly set one. 87 # Android versionName for android_apk()s that don't expclitly set one.
88 android_default_version_name = "Developer Build" 88 android_default_version_name = "Developer Build"
89 89
90 # The path to the keystore to use for signing builds. 90 # The path to the keystore to use for signing builds.
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 "//build/toolchain/android:${android_secondary_abi_cpu}" 322 "//build/toolchain/android:${android_secondary_abi_cpu}"
323 } 323 }
324 } 324 }
325 } 325 }
326 326
327 declare_args() { 327 declare_args() {
328 # Enables used resource whitelist generation. Set for official builds only 328 # Enables used resource whitelist generation. Set for official builds only
329 # as a large amount of build output is generated. 329 # as a large amount of build output is generated.
330 enable_resource_whitelist_generation = is_android && is_official_build 330 enable_resource_whitelist_generation = is_android && is_official_build
331 } 331 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698