Start hiding deprecated skia/ext/ functions

Start hiding deprecated skia/ext/ functions

skia::GetTopDevice() gets removed from our public API.
SK_API also removed from a couple of classes we don't want used.

R=fmalita@chromium.org
BUG=543755
Committed: https://crrev.com/efe03ce5f03fb01ba096abd98698cd37c2a0e7a3
Cr-Commit-Position: refs/heads/master@{#415387}

[tomhudson, 2016-08-30 15:15:01]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 15:15:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tomhudson, 2016-08-30 15:15:24]

PTAL; I also want to hide {Get,Set}PlatformDevice() but that's not quite so
trivial.

[commit-bot: I haz the power, 2016-08-30 15:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 15:26:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tomhudson, 2016-08-30 15:28:26]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 15:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 15:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 15:58:58]

Dry run: Exceeded global retry quota

[f(malita), 2016-08-30 17:41:23]

LGTM % linker errors.

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/bitmap_platfor...
File skia/ext/bitmap_platform_device_mac.h (left):

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/bitmap_platfor...
skia/ext/bitmap_platform_device_mac.h:30: class SK_API BitmapPlatformDevice :
public SkBitmapDevice, public PlatformDevice {
I think we need to keep these exported, otherwise the linker throws a fit.

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_canva...
File skia/ext/platform_canvas_unittest.cc (right):

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_canva...
skia/ext/platform_canvas_unittest.cc:87: SkBaseDevice* device,
Nit: since device is always derived from canvas, it could be misleading to
expose as an explicit param.  Can we use canvas.getTopDevice(true) on the fly
instead?

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_device.h
File skia/ext/platform_device.h (left):

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_devic...
skia/ext/platform_device.h:37: SK_API void SetPlatformDevice(SkBaseDevice*
device,
Same comment about exporting.

[tomhudson, 2016-08-30 17:48:38]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-08-30 17:48:39]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2294813002/#ps60001
(title: "review")

[tomhudson, 2016-08-30 17:48:48]

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/bitmap_platfor...
File skia/ext/bitmap_platform_device_mac.h (left):

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/bitmap_platfor...
skia/ext/bitmap_platform_device_mac.h:30: class SK_API BitmapPlatformDevice :
public SkBitmapDevice, public PlatformDevice {
On 2016/08/30 17:41:23, f(malita) wrote:
> I think we need to keep these exported, otherwise the linker throws a fit.

Done.

I'm guessing we do symbolic linking with unit tests on Mac?

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_canva...
File skia/ext/platform_canvas_unittest.cc (right):

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_canva...
skia/ext/platform_canvas_unittest.cc:87: SkBaseDevice* device,
On 2016/08/30 17:41:23, f(malita) wrote:
> Nit: since device is always derived from canvas, it could be misleading to
> expose as an explicit param.  Can we use canvas.getTopDevice(true) on the fly
> instead?

D'oh, yes.

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_device.h
File skia/ext/platform_device.h (left):

https://codereview.chromium.org/2294813002/diff/40001/skia/ext/platform_devic...
skia/ext/platform_device.h:37: SK_API void SetPlatformDevice(SkBaseDevice*
device,
On 2016/08/30 17:41:23, f(malita) wrote:
> Same comment about exporting.

Done.

[commit-bot: I haz the power, 2016-08-30 17:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-08-30 17:53:15]

https://codereview.chromium.org/2294813002/diff/60001/skia/ext/bitmap_platfor...
File skia/ext/bitmap_platform_device_win.h (left):

https://codereview.chromium.org/2294813002/diff/60001/skia/ext/bitmap_platfor...
skia/ext/bitmap_platform_device_win.h:22: class SK_API BitmapPlatformDevice :
public SkBitmapDevice, public PlatformDevice {
It would be safer to leave this export alone also (not sure we have enough
trybots to cover all real build configs).

[tomhudson, 2016-08-30 17:59:36]

The CQ bit was unchecked by tomhudson@google.com

[tomhudson, 2016-08-30 18:03:40]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-08-30 18:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2294813002/#ps80001
(title: "re-add another SK_API")

[commit-bot: I haz the power, 2016-08-30 18:04:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:14:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-30 19:17:50]

Description was changed from

==========
Start hiding deprecated skia/ext/ functions

skia::GetTopDevice() gets removed from our public API.
SK_API also removed from a couple of classes we don't want used.

R=fmalita@chromium.org
BUG=543755
==========

to

==========
Start hiding deprecated skia/ext/ functions

skia::GetTopDevice() gets removed from our public API.
SK_API also removed from a couple of classes we don't want used.

R=fmalita@chromium.org
BUG=543755

Committed: https://crrev.com/efe03ce5f03fb01ba096abd98698cd37c2a0e7a3
Cr-Commit-Position: refs/heads/master@{#415387}
==========

[commit-bot: I haz the power, 2016-08-30 19:17:51]

Patchset 5 (id:??) landed as
https://crrev.com/efe03ce5f03fb01ba096abd98698cd37c2a0e7a3
Cr-Commit-Position: refs/heads/master@{#415387}