Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2294783002: Fix step size computation in IncrementalMarking::AdvanceIncrementalMarking. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix step size computation in IncrementalMarking::AdvanceIncrementalMarking. BUG=chromium:616434 LOG=NO Committed: https://crrev.com/1b8fd0dd4ba7d50e664cf265273ef70e70c7cc52 Cr-Commit-Position: refs/heads/master@{#39024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ulan
PTAL. This fixes a bug.
4 years, 3 months ago (2016-08-30 13:58:42 UTC) #2
Michael Lippautz
On 2016/08/30 13:58:42, ulan wrote: > PTAL. This fixes a bug. lgtm
4 years, 3 months ago (2016-08-30 16:38:00 UTC) #4
Michael Lippautz
On 2016/08/30 13:58:42, ulan wrote: > PTAL. This fixes a bug. lgtm
4 years, 3 months ago (2016-08-30 16:38:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294783002/1
4 years, 3 months ago (2016-08-30 16:38:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:58:43 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:59:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b8fd0dd4ba7d50e664cf265273ef70e70c7cc52
Cr-Commit-Position: refs/heads/master@{#39024}

Powered by Google App Engine
This is Rietveld 408576698