Handle parts as input in resolver.

Handle parts as input in resolver.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/64a2a03f0e0784aaa8f29418ea32c93989b8e9b6

[Johnni Winther, 2016-08-30 11:22:41]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Johnni Winther, 2016-08-30 11:22:42]

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/consta...
File pkg/compiler/lib/src/constants/constant_constructors.dart (right):

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/consta...
pkg/compiler/lib/src/constants/constant_constructors.dart:271:
ConstantExpression visitEquals(Send node, Node left, Node right, _) {
Missing implementation triggered by the test.

[Harry Terkelsen, 2016-08-30 16:31:50]

lgtm

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js_resolver.dart (right):

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js_resolver.dart:40: platformConfig != null ?
libraryRoot.resolve(platformConfig) : null);
nit: be consistent with the above ternary for packageConfig

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js_resolver.dart:58: if (library != null) {
so if library == null then the uri points to a part file? maybe add a comment
clarifying why we don't just serialize every input

[Johnni Winther, 2016-08-31 08:49:51]

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/dart2j...
File pkg/compiler/lib/src/dart2js_resolver.dart (right):

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js_resolver.dart:40: platformConfig != null ?
libraryRoot.resolve(platformConfig) : null);
On 2016/08/30 16:31:50, Harry Terkelsen wrote:
> nit: be consistent with the above ternary for packageConfig

Done.

https://codereview.chromium.org/2294753002/diff/1/pkg/compiler/lib/src/dart2j...
pkg/compiler/lib/src/dart2js_resolver.dart:58: if (library != null) {
On 2016/08/30 16:31:50, Harry Terkelsen wrote:
> so if library == null then the uri points to a part file? maybe add a comment
> clarifying why we don't just serialize every input

Done.

[Johnni Winther, 2016-08-31 09:04:49]

Description was changed from

==========
Handle parts as input in resolver.
==========

to

==========
Handle parts as input in resolver.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64a2a03f0e0784aaa8f29418ea32c93989b8e9b6
==========

[Johnni Winther, 2016-08-31 09:04:50]

Committed patchset #2 (id:20001) manually as
64a2a03f0e0784aaa8f29418ea32c93989b8e9b6 (presubmit successful).