[wasm] simd scalar lowering F32x4Add and I32x4Add

test/cctest/wasm/test-run-wasm-simd-lowering.cc

+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/wasm/wasm-macro-gen.h"
+#include "src/wasm/wasm-module.h"
+
+#include "test/cctest/cctest.h"
+#include "test/cctest/wasm/test-run-wasm-module-helper.h"
+#include "test/cctest/wasm/test-signatures.h"
+
+using namespace v8::base;
+using namespace v8::internal;
+using namespace v8::internal::compiler;
+using namespace v8::internal::wasm;
+
+namespace {
+void SimpleTest(byte* code, uint32_t size, int32_t result) {
+  FLAG_wasm_simd_prototype = true;
+  TestSignatures sigs;
+  v8::base::AccountingAllocator allocator;
+  Zone zone(&allocator);
+
+  WasmModuleBuilder* builder = new (&zone) WasmModuleBuilder(&zone);
+  uint16_t f_index = builder->AddFunction();
+  WasmFunctionBuilder* f = builder->FunctionAt(f_index);
+  f->SetSignature(sigs.i_v());
+  TestRunWasmModuleHelper::ExportAsMain(f);
+  f->EmitCode(code, size);
+  TestRunWasmModuleHelper::TestModule(&zone, builder, result);
+}
+}  // namespace
+
+TEST(Simd_I32x4_Splat) {

[gdeepti, 2016/08/30 17:16:06]

WASM_EXEC_TEST here could work here too if you want less overhead. A scalar
lowering pass for testing in wasm-run-utils.h might need to be added for the
tests to work correctly. (See Int64LoweringForTesting())

[aseemgarg, 2016/10/10 17:35:17]

Done.

+  byte code[] = {WASM_SIMD_I32x4_EXTRACT_LANE(
+      WASM_SIMD_I32x4_SPLAT(WASM_I32V(5)), WASM_I8(0))};
+  SimpleTest(code, sizeof(code), 5);
+}
+
+TEST(Simd_I32x4_Add) {
+  byte code[] = {WASM_SIMD_I32x4_EXTRACT_LANE(
+      WASM_SIMD_I32x4_ADD(WASM_SIMD_I32x4_SPLAT(WASM_I32V(5)),
+                          WASM_SIMD_I32x4_SPLAT(WASM_I32V(6))),
+      WASM_I8(0))};
+  SimpleTest(code, sizeof(code), 11);
+}
+
+TEST(Simd_F32x4_Splat) {
+  byte code[] = {WASM_IF_ELSE(
+      WASM_F32_EQ(WASM_SIMD_F32x4_EXTRACT_LANE(
+                      WASM_SIMD_F32x4_SPLAT(WASM_F32(9.5)), WASM_I32V(0)),
+                  WASM_F32(9.5)),
+      WASM_RETURN1(WASM_I32V(1)), WASM_RETURN1(WASM_I32V(0)))};
+  SimpleTest(code, sizeof(code), 1);
+}
+
+TEST(Simd_F32x4_Add) {
+  byte code[] = {WASM_IF_ELSE(
+      WASM_F32_EQ(
+          WASM_SIMD_F32x4_EXTRACT_LANE(
+              WASM_SIMD_F32x4_ADD(WASM_SIMD_F32x4_SPLAT(WASM_F32(13.25)),
+                                  WASM_SIMD_F32x4_SPLAT(WASM_F32(6.25))),
+              WASM_I8(0)),
+          WASM_F32(19.5)),
+      WASM_RETURN1(WASM_I32V(1)), WASM_RETURN1(WASM_I32V(0)))};
+  SimpleTest(code, sizeof(code), 1);
+}
+
+TEST(Simd_I32x4_Extract_With_F32x4) {
+  byte code[] = {WASM_IF_ELSE(
+      WASM_I32_EQ(WASM_SIMD_I32x4_EXTRACT_LANE(
+                      WASM_SIMD_F32x4_SPLAT(WASM_F32(30.5)), WASM_I32V(0)),
+                  WASM_I32_REINTERPRET_F32(WASM_F32(30.5))),
+      WASM_RETURN1(WASM_I32V(1)), WASM_RETURN1(WASM_I32V(0)))};
+  SimpleTest(code, sizeof(code), 1);
+}
+
+TEST(Simd_F32x4_Extract_With_I32x4) {
+  byte code[] = {WASM_IF_ELSE(
+      WASM_F32_EQ(WASM_SIMD_F32x4_EXTRACT_LANE(
+                      WASM_SIMD_I32x4_SPLAT(WASM_I32V(15)), WASM_I32V(0)),
+                  WASM_F32_REINTERPRET_I32(WASM_I32V(15))),
+      WASM_RETURN1(WASM_I32V(1)), WASM_RETURN1(WASM_I32V(0)))};
+  SimpleTest(code, sizeof(code), 1);
+}
+
+TEST(Simd_F32x4_Add_With_I32x4) {
+  byte code[] = {WASM_IF_ELSE(
+      WASM_F32_EQ(WASM_SIMD_F32x4_EXTRACT_LANE(
+                      WASM_SIMD_F32x4_ADD(WASM_SIMD_I32x4_SPLAT(WASM_I32V(32)),
+                                          WASM_SIMD_I32x4_SPLAT(WASM_I32V(19))),
+                      WASM_I8(0)),
+                  WASM_F32_ADD(WASM_F32_REINTERPRET_I32(WASM_I32V(32)),
+                               WASM_F32_REINTERPRET_I32(WASM_I32V(19)))),
+      WASM_RETURN1(WASM_I32V(1)), WASM_RETURN1(WASM_I32V(0)))};
+  SimpleTest(code, sizeof(code), 1);
+}
+
+TEST(Simd_I32x4_Add_With_F32x4) {
+  byte code[] = {WASM_IF_ELSE(
+      WASM_I32_EQ(
+          WASM_SIMD_I32x4_EXTRACT_LANE(
+              WASM_SIMD_I32x4_ADD(WASM_SIMD_F32x4_SPLAT(WASM_F32(21.25)),
+                                  WASM_SIMD_F32x4_SPLAT(WASM_F32(31.5))),
+              WASM_I8(0)),
+          WASM_I32_ADD(WASM_I32_REINTERPRET_F32(WASM_F32(21.25)),
+                       WASM_I32_REINTERPRET_F32(WASM_F32(31.5)))),
+      WASM_RETURN1(WASM_I32V(1)), WASM_RETURN1(WASM_I32V(0)))};
+  SimpleTest(code, sizeof(code), 1);

[bradnelson, 2016/08/31 22:42:08]

I assume you'll want tests with loops + conditions to cover the phis with cycle
case.
You're avoiding that for now for lack of get_local / set_local ?

[aseemgarg, 2016/10/10 17:35:17]

yes. Will do in next change.

+}