Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2294733004: Revert of [Mac][Material Design] Fix toolbar height on Retina. (Closed)

Created:
4 years, 3 months ago by shrike
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac][Material Design] Fix toolbar height on Retina. (patchset #3 id:40001 of https://codereview.chromium.org/1948963002/ ) Reason for revert: Testing for cause of regression. Original issue's description: > [Mac][Material Design] Fix toolbar height on Retina. > > A recent change to center the toolbar's buttons and textfield on > Retina displays throws them off-center on Retina when in Material > Design. This change bypasses the adjustment in this case. > > Note that on Retina there is an odd number of pixels between the top > and bottom edges of the toolbar, which means that the location bar's > contents cannot be exactly centered. This is per spec (it also > occurs on ChromeOS). > > Lastly, this cl makes the location bar shadow color transparent. > > R=avi@chromium.org > BUG=605140 > > Committed: https://crrev.com/90b73afb789c6a84ce25579c08bb4ac55164c768 > Cr-Commit-Position: refs/heads/master@{#392379} TBR=avi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -37 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +6 lines, -20 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shrike
4 years, 3 months ago (2016-08-30 17:40:13 UTC) #1
Created Revert of [Mac][Material Design] Fix toolbar height on Retina.

Powered by Google App Engine
This is Rietveld 408576698