Issue 229473002: A handful of nits found while working on blobs.

Issue 229473002: A handful of nits found while working on blobs. (Closed)

Created:
6 years, 8 months ago by ericu

Modified:
6 years, 8 months ago

Reviewers:
kinuko, jsbell, cmumford

CC:
chromium-reviews, tzik, jam, alecflett, nhiroki, darin-cc_chromium.org, ericu+idb_chromium.org, cmumford, dgrogan, kinuko+watch, jsbell+idb_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

A handful of nits found while working on blobs. I'd just like to check them in to drop a few files out of the big CL. The DISALLOW_COPY_AND_ASSIGN isn't needed, and has to go for the big CL anyway. BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262706

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	content/browser/fileapi/fileapi_message_filter.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_index_writer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_index_writer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/indexed_db_leveldb_coding.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/browser/blob/blob_storage_context.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/229473002/1

6 years, 8 months ago (2014-04-08 22:52:56 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-08 23:32:56 UTC) #6

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60268

6 years, 8 months ago (2014-04-08 23:32:56 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/229473002/1

6 years, 8 months ago (2014-04-09 13:27:30 UTC) #11

Message was sent while issue was closed.

Change committed as 262706

Expand Messages | Collapse Messages