Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2294723002: Revert of Redirect all mouse input to Alt+Tab window when it's visible, (Closed)

Created:
4 years, 3 months ago by perkj_chrome
Modified:
4 years, 3 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Redirect all mouse input to Alt+Tab window when it's visible, (patchset #3 id:40001 of https://codereview.chromium.org/2284763002/ ) Reason for revert: WindowCycleControllerTest.MouseCaptureLost fails on Chrome os and Asan. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(dbg)(1) Original issue's description: > Redirect all mouse input to Alt+Tab window when it's visible, > effectively disabling the mouse. Capture is reset when the widget is > destroyed. > > BUG=641171 > > Committed: https://crrev.com/c7e292ea58a76fe27c6c247bc640054bcf4cb6aa > Cr-Commit-Position: refs/heads/master@{#415096} TBR=sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641171 Committed: https://crrev.com/95797140da851b1078706ae6146cb8062d7498eb Cr-Commit-Position: refs/heads/master@{#415267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -85 lines) Patch
M ash/common/wm/window_cycle_list.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 3 chunks +20 lines, -79 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_chrome
Created Revert of Redirect all mouse input to Alt+Tab window when it's visible,
4 years, 3 months ago (2016-08-30 10:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294723002/1
4 years, 3 months ago (2016-08-30 10:47:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 10:48:39 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 10:50:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95797140da851b1078706ae6146cb8062d7498eb
Cr-Commit-Position: refs/heads/master@{#415267}

Powered by Google App Engine
This is Rietveld 408576698