Add signMask getter to Float32x4

runtime/vm/intermediate_language.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 76 matching lines @@
   V(::, min, MathMin, 1584022354)                                              \
   V(::, max, MathMax, 328632232)                                               \
   V(Float32x4, Float32x4., Float32x4Constructor, 1876089990)                   \
   V(Float32x4, Float32x4.zero, Float32x4Zero, 1903586222)                      \
   V(Float32x4, Float32x4.splat, Float32x4Splat, 38462589)                      \
   V(_Float32x4, shuffle, Float32x4Shuffle, 713523911)                          \
   V(_Float32x4, get:x, Float32x4ShuffleX, 1019523296)                          \
   V(_Float32x4, get:y, Float32x4ShuffleY, 710282243)                           \
   V(_Float32x4, get:z, Float32x4ShuffleZ, 1612806041)                          \
   V(_Float32x4, get:w, Float32x4ShuffleW, 1113701403)                          \
+  V(_Float32x4, get:signMask, Float32x4GetSignMask, 465347632)                 \
   V(_Float32x4, _cmpequal, Float32x4Equal, 1559121703)                         \
   V(_Float32x4, _cmpgt, Float32x4GreaterThan, 1959692892)                      \
   V(_Float32x4, _cmpgte, Float32x4GreaterThanOrEqual, 2128251808)              \
   V(_Float32x4, _cmplt, Float32x4LessThan, 405464198)                          \
   V(_Float32x4, _cmplte, Float32x4LessThanOrEqual, 1217836152)                 \
   V(_Float32x4, _cmpnequal, Float32x4NotEqual, 498820440)                      \
   V(_Float32x4, _min, Float32x4Min, 1354880316)                                \
   V(_Float32x4, _max, Float32x4Max, 171574145)                                 \
   V(_Float32x4, _scale, Float32x4Scale, 1553559438)                            \
   V(_Float32x4, _sqrt, Float32x4Sqrt, 612006112)                               \
@@ skipping 10 matching lines @@
   V(_Float32x4, withZWInXY, Float32x4WithZWInXY, 1850941421)                   \
   V(_Float32x4, interleaveXY, Float32x4InterleaveXY, 1789523505)               \
   V(_Float32x4, interleaveZW, Float32x4InterleaveZW, 1137302773)               \
   V(_Float32x4, interleaveXYPairs, Float32x4InterleaveXYPairs, 2138669236)     \
   V(_Float32x4, interleaveZWPairs, Float32x4InterleaveZWPairs, 1541966446)     \
   V(Uint32x4, Uint32x4.bool, Uint32x4BoolConstructor, 733327933)               \
   V(_Uint32x4, get:flagX, Uint32x4GetFlagX, 765894409)                         \
   V(_Uint32x4, get:flagY, Uint32x4GetFlagY, 1226233321)                        \
   V(_Uint32x4, get:flagZ, Uint32x4GetFlagZ, 1455452476)                        \
   V(_Uint32x4, get:flagW, Uint32x4GetFlagW, 1608549245)                        \
+  V(_Uint32x4, get:signMask, Uint32x4GetSignMask, 231202664)                   \
   V(_Uint32x4, select, Uint32x4Select, 881590808)                              \
   V(_Uint32x4, withFlagX, Uint32x4WithFlagX, 1987921054)                       \
   V(_Uint32x4, withFlagY, Uint32x4WithFlagY, 831632614)                        \
   V(_Uint32x4, withFlagZ, Uint32x4WithFlagZ, 465765612)                        \
   V(_Uint32x4, withFlagW, Uint32x4WithFlagW, 1545009993)                       \
   V(_Uint32x4, _toFloat32x4, Uint32x4ToUint32x4, 1545735523)                   \
 
 
 // A list of core function that should always be inlined.
 #define INLINE_WHITE_LIST(V)                                                   \
@@ skipping 469 matching lines @@
   M(ShiftMintOp)                                                               \
   M(UnaryMintOp)                                                               \
   M(CheckArrayBound)                                                           \
   M(Constraint)                                                                \
   M(StringFromCharCode)                                                        \
   M(InvokeMathCFunction)                                                       \
   M(GuardField)                                                                \
   M(IfThenElse)                                                                \
   M(BinaryFloat32x4Op)                                                         \
   M(Float32x4Shuffle)                                                          \
+  M(Float32x4GetSignMask)                                                      \
   M(Float32x4Constructor)                                                      \
   M(Float32x4Zero)                                                             \
   M(Float32x4Splat)                                                            \
   M(Float32x4Comparison)                                                       \
   M(Float32x4MinMax)                                                           \
   M(Float32x4Scale)                                                            \
   M(Float32x4Sqrt)                                                             \
   M(Float32x4ZeroArg)                                                          \
   M(Float32x4Clamp)                                                            \
   M(Float32x4With)                                                             \
   M(Float32x4ToUint32x4)                                                       \
   M(Float32x4TwoArgShuffle)                                                    \
   M(MaterializeObject)                                                         \
   M(Uint32x4BoolConstructor)                                                   \
   M(Uint32x4GetFlag)                                                           \
+  M(Uint32x4GetSignMask)                                                       \
   M(Uint32x4Select)                                                            \
   M(Uint32x4SetFlag)                                                           \
   M(Uint32x4ToFloat32x4)                                                       \
   M(BinaryUint32x4Op)                                                          \
 
 
 #define FORWARD_DECLARATION(type) class type##Instr;
 FOR_EACH_INSTRUCTION(FORWARD_DECLARATION)
 #undef FORWARD_DECLARATION
 
@@ skipping 254 matching lines @@
   // Classes that set or read deopt_id_.
   friend class UnboxIntegerInstr;
   friend class UnboxDoubleInstr;
   friend class UnboxFloat32x4Instr;
   friend class UnboxUint32x4Instr;
   friend class BinaryDoubleOpInstr;
   friend class BinaryFloat32x4OpInstr;
   friend class Float32x4ZeroInstr;
   friend class Float32x4SplatInstr;
   friend class Float32x4ShuffleInstr;
+  friend class Float32x4GetSignMaskInstr;
   friend class Float32x4ConstructorInstr;
   friend class Float32x4ComparisonInstr;
   friend class Float32x4MinMaxInstr;
   friend class Float32x4ScaleInstr;
   friend class Float32x4SqrtInstr;
   friend class Float32x4ZeroArgInstr;
   friend class Float32x4ClampInstr;
   friend class Float32x4WithInstr;
   friend class Float32x4ToUint32x4Instr;
   friend class Float32x4TwoArgShuffleInstr;
   friend class Uint32x4BoolConstructorInstr;
   friend class Uint32x4GetFlagInstr;
+  friend class Uint32x4GetSignMaskInstr;
   friend class Uint32x4SetFlagInstr;
   friend class Uint32x4SelectInstr;
   friend class Uint32x4ToFloat32x4Instr;
   friend class BinaryUint32x4OpInstr;
   friend class BinaryMintOpInstr;
   friend class BinarySmiOpInstr;
   friend class UnarySmiOpInstr;
   friend class UnaryDoubleOpInstr;
   friend class ShiftMintOpInstr;
   friend class UnaryMintOpInstr;
@@ skipping 4593 matching lines @@
 
   virtual bool MayThrow() const { return false; }
 
  private:
   const MethodRecognizer::Kind op_kind_;
 
   DISALLOW_COPY_AND_ASSIGN(Uint32x4GetFlagInstr);
 };
 
 
+class Uint32x4GetSignMaskInstr : public TemplateDefinition<1> {

[srdjan, 2013/08/19 17:30:27]

Could you merge the two instructions?

[Cutch, 2013/08/19 17:53:21]

Done.

+ public:
+  Uint32x4GetSignMaskInstr(Value* value, intptr_t deopt_id) {
+    SetInputAt(0, value);
+    deopt_id_ = deopt_id;
+  }
+
+  Value* value() const { return inputs_[0]; }
+
+  virtual void PrintOperandsTo(BufferFormatter* f) const;
+
+  virtual bool CanDeoptimize() const { return false; }
+
+  virtual Representation representation() const {
+      return kTagged;

[srdjan, 2013/08/19 17:30:27]

Indent bad

[Cutch, 2013/08/19 17:53:21]

Done.

+  }
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    ASSERT(idx == 0);
+    return kUnboxedUint32x4;
+  }
+
+  virtual intptr_t DeoptimizationTarget() const {
+    // Direct access since this instruction cannot deoptimize, and the deopt-id
+    // was inherited from another instruction that could deoptimize.
+    return deopt_id_;
+  }
+
+  DECLARE_INSTRUCTION(Uint32x4GetSignMask)
+  virtual CompileType ComputeType() const;
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const {
+    return true;
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(Uint32x4GetSignMaskInstr);
+};
+
+
+class Float32x4GetSignMaskInstr : public TemplateDefinition<1> {
+ public:
+  Float32x4GetSignMaskInstr(Value* value, intptr_t deopt_id) {
+    SetInputAt(0, value);
+    deopt_id_ = deopt_id;
+  }
+
+  Value* value() const { return inputs_[0]; }
+
+  virtual void PrintOperandsTo(BufferFormatter* f) const;
+
+  virtual bool CanDeoptimize() const { return false; }
+
+  virtual Representation representation() const {
+      return kTagged;

[srdjan, 2013/08/19 17:30:27]

ditto

[Cutch, 2013/08/19 17:53:21]

Done.

+  }
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    ASSERT(idx == 0);
+    return kUnboxedFloat32x4;
+  }
+
+  virtual intptr_t DeoptimizationTarget() const {
+    // Direct access since this instruction cannot deoptimize, and the deopt-id
+    // was inherited from another instruction that could deoptimize.
+    return deopt_id_;
+  }
+
+  DECLARE_INSTRUCTION(Float32x4GetSignMask)
+  virtual CompileType ComputeType() const;
+
+  virtual bool AllowsCSE() const { return true; }
+  virtual EffectSet Effects() const { return EffectSet::None(); }
+  virtual EffectSet Dependencies() const { return EffectSet::None(); }
+  virtual bool AttributesEqual(Instruction* other) const {
+    return true;
+  }
+
+  virtual bool MayThrow() const { return false; }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(Float32x4GetSignMaskInstr);
+};
+
+
 class Float32x4TwoArgShuffleInstr : public TemplateDefinition<2> {
  public:
   Float32x4TwoArgShuffleInstr(MethodRecognizer::Kind op_kind, Value* left,
                               Value* right, intptr_t deopt_id)
       : op_kind_(op_kind) {
     SetInputAt(0, left);
     SetInputAt(1, right);
     deopt_id_ = deopt_id;
   }
 
@@ skipping 1135 matching lines @@
   ForwardInstructionIterator* current_iterator_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_