Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: extensions/browser/api/system_storage/system_storage_apitest.cc

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/storage/settings_test_util.h ('k') | extensions/browser/blob_holder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/system_storage/system_storage_apitest.cc
diff --git a/extensions/browser/api/system_storage/system_storage_apitest.cc b/extensions/browser/api/system_storage/system_storage_apitest.cc
index 3d0168cace717b56428e92a5350e18f3a75939cb..5e442bb86c41e997660223b5d4b4b0fc4f651bc9 100644
--- a/extensions/browser/api/system_storage/system_storage_apitest.cc
+++ b/extensions/browser/api/system_storage/system_storage_apitest.cc
@@ -7,7 +7,7 @@
#include <vector>
#include "base/macros.h"
-#include "base/memory/linked_ptr.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "components/storage_monitor/storage_monitor.h"
@@ -110,14 +110,14 @@ IN_PROC_BROWSER_TEST_F(SystemStorageApiTest, Storage) {
TestStorageInfoProvider* provider =
new TestStorageInfoProvider(kTestingData, arraysize(kTestingData));
extensions::StorageInfoProvider::InitializeForTesting(provider);
- std::vector<linked_ptr<ExtensionTestMessageListener>> device_ids_listeners;
+ std::vector<std::unique_ptr<ExtensionTestMessageListener>>
+ device_ids_listeners;
for (size_t i = 0; i < arraysize(kTestingData); ++i) {
- linked_ptr<ExtensionTestMessageListener> listener(
- new ExtensionTestMessageListener(
+ device_ids_listeners.push_back(
+ base::MakeUnique<ExtensionTestMessageListener>(
StorageMonitor::GetInstance()->GetTransientIdForDeviceId(
kTestingData[i].device_id),
false));
- device_ids_listeners.push_back(listener);
}
ASSERT_TRUE(RunAppTest("system/storage")) << message_;
for (size_t i = 0; i < device_ids_listeners.size(); ++i)
« no previous file with comments | « extensions/browser/api/storage/settings_test_util.h ('k') | extensions/browser/blob_holder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698