Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: extensions/browser/api/storage/local_value_store_cache.cc

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/storage/local_value_store_cache.cc
diff --git a/extensions/browser/api/storage/local_value_store_cache.cc b/extensions/browser/api/storage/local_value_store_cache.cc
index f0aed27742d24af16612d3c9cab805e89638ff00..ef91d20d58abc7ef8ed0782bdd79a0f670946a6c 100644
--- a/extensions/browser/api/storage/local_value_store_cache.cc
+++ b/extensions/browser/api/storage/local_value_store_cache.cc
@@ -81,12 +81,13 @@ ValueStore* LocalValueStoreCache::GetStorage(const Extension* extension) {
: ValueStoreFactory::ModelType::EXTENSION;
std::unique_ptr<ValueStore> store = storage_factory_->CreateSettingsStore(
settings_namespace::LOCAL, model_type, extension->id());
- linked_ptr<SettingsStorageQuotaEnforcer> storage(
+ std::unique_ptr<SettingsStorageQuotaEnforcer> storage(
new SettingsStorageQuotaEnforcer(quota_, std::move(store)));
DCHECK(storage.get());
- storage_map_[extension->id()] = storage;
- return storage.get();
+ ValueStore* storage_ptr = storage.get();
+ storage_map_[extension->id()] = std::move(storage);
+ return storage_ptr;
}
} // namespace extensions
« no previous file with comments | « extensions/browser/api/storage/local_value_store_cache.h ('k') | extensions/browser/api/storage/settings_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698