chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc - Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/extensions/external_provider_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc

diff --git a/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc b/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc

index 1601dc3f7f1fcfb8b0129ebd7658d85fd927ff24..3a4051597b1b2fdd36060482bbd6320e7f18cb0b 100644

--- a/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc

+++ b/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc

@@ -71,11 +71,8 @@ class ExternalProviderImplChromeOSTest : public ExtensionServiceTestBase {

extensions::ExternalProviderImpl::CreateExternalProviders(

service_, profile_.get(), &providers);

- for (ProviderCollection::iterator i = providers.begin();

- i != providers.end();

- ++i) {

- service_->AddProviderForTesting(i->release());

- }

+ for (std::unique_ptr<ExternalProviderInterface>& provider : providers)

+ service_->AddProviderForTesting(std::move(provider));

}

// ExtensionServiceTestBase overrides: