chrome/browser/extensions/extension_service.h - Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.h

diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h

index 0f1ea91ff6e8a66f91ce3a7ee1f4396547f1c94d..bb05d2af47223011aa5eebb92458ab059e2e2754 100644

--- a/chrome/browser/extensions/extension_service.h

+++ b/chrome/browser/extensions/extension_service.h

@@ -429,9 +429,8 @@ class ExtensionService

void ClearProvidersForTesting();

// Adds an ExternalProviderInterface for the service to use during testing.

- // Takes ownership of |test_provider|.

void AddProviderForTesting(

- extensions::ExternalProviderInterface* test_provider);

+ std::unique_ptr<extensions::ExternalProviderInterface> test_provider);

// Simulate an extension being blacklisted for tests.

void BlacklistExtensionForTest(const std::string& extension_id);