Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/api/system_storage/system_storage_apitest.cc

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)
Patch Set: nullptr Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/system_storage/system_storage_apitest.cc
diff --git a/extensions/browser/api/system_storage/system_storage_apitest.cc b/extensions/browser/api/system_storage/system_storage_apitest.cc
index 3d0168cace717b56428e92a5350e18f3a75939cb..d3dc8949ac19eb29837019482b4a0e4202e8cc98 100644
--- a/extensions/browser/api/system_storage/system_storage_apitest.cc
+++ b/extensions/browser/api/system_storage/system_storage_apitest.cc
@@ -7,7 +7,6 @@
#include <vector>
#include "base/macros.h"
-#include "base/memory/linked_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "components/storage_monitor/storage_monitor.h"
@@ -110,14 +109,15 @@ IN_PROC_BROWSER_TEST_F(SystemStorageApiTest, Storage) {
TestStorageInfoProvider* provider =
new TestStorageInfoProvider(kTestingData, arraysize(kTestingData));
extensions::StorageInfoProvider::InitializeForTesting(provider);
- std::vector<linked_ptr<ExtensionTestMessageListener>> device_ids_listeners;
+ std::vector<std::unique_ptr<ExtensionTestMessageListener>>
+ device_ids_listeners;
for (size_t i = 0; i < arraysize(kTestingData); ++i) {
- linked_ptr<ExtensionTestMessageListener> listener(
+ std::unique_ptr<ExtensionTestMessageListener> listener(
new ExtensionTestMessageListener(
StorageMonitor::GetInstance()->GetTransientIdForDeviceId(
kTestingData[i].device_id),
false));
- device_ids_listeners.push_back(listener);
+ device_ids_listeners.push_back(std::move(listener));
Devlin 2016/08/30 19:21:53 optional: inline listener with a base::MakeUnique
lazyboy 2016/08/30 20:30:56 Done.
}
ASSERT_TRUE(RunAppTest("system/storage")) << message_;
for (size_t i = 0; i < device_ids_listeners.size(); ++i)

Powered by Google App Engine
This is Rietveld 408576698