Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: extensions/browser/content_verifier_io_data.cc

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)
Patch Set: nullptr Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/content_verifier_io_data.h" 5 #include "extensions/browser/content_verifier_io_data.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "content/public/browser/browser_thread.h" 9 #include "content/public/browser/browser_thread.h"
10 10
(...skipping 12 matching lines...) Expand all
23 ContentVerifierIOData::ExtensionData::~ExtensionData() { 23 ContentVerifierIOData::ExtensionData::~ExtensionData() {
24 } 24 }
25 25
26 ContentVerifierIOData::~ContentVerifierIOData() { 26 ContentVerifierIOData::~ContentVerifierIOData() {
27 } 27 }
28 28
29 void ContentVerifierIOData::AddData(const std::string& extension_id, 29 void ContentVerifierIOData::AddData(const std::string& extension_id,
30 std::unique_ptr<ExtensionData> data) { 30 std::unique_ptr<ExtensionData> data) {
31 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 31 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
32 CHECK(data->browser_image_paths.get()); 32 CHECK(data->browser_image_paths.get());
33 data_map_[extension_id] = linked_ptr<ExtensionData>(data.release()); 33 data_map_[extension_id] = std::move(data);
34 } 34 }
35 35
36 void ContentVerifierIOData::RemoveData(const std::string& extension_id) { 36 void ContentVerifierIOData::RemoveData(const std::string& extension_id) {
37 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 37 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
38 std::map<std::string, linked_ptr<ExtensionData> >::iterator found = 38 std::map<std::string, std::unique_ptr<ExtensionData>>::iterator found =
39 data_map_.find(extension_id); 39 data_map_.find(extension_id);
40 if (found != data_map_.end()) 40 if (found != data_map_.end())
Devlin 2016/08/30 19:21:53 ?? Why not do data_map_.erase(extension_id);? (No
lazyboy 2016/08/30 20:30:56 Thanks for noticing, done.
41 data_map_.erase(found); 41 data_map_.erase(found);
42 } 42 }
43 43
44 void ContentVerifierIOData::Clear() { 44 void ContentVerifierIOData::Clear() {
45 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 45 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
46 data_map_.clear(); 46 data_map_.clear();
47 } 47 }
48 48
49 const ContentVerifierIOData::ExtensionData* ContentVerifierIOData::GetData( 49 const ContentVerifierIOData::ExtensionData* ContentVerifierIOData::GetData(
50 const std::string& extension_id) { 50 const std::string& extension_id) {
51 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 51 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
52 std::map<std::string, linked_ptr<ExtensionData> >::iterator found = 52 std::map<std::string, std::unique_ptr<ExtensionData>>::iterator found =
53 data_map_.find(extension_id); 53 data_map_.find(extension_id);
54 if (found != data_map_.end()) 54 if (found != data_map_.end())
55 return found->second.get(); 55 return found->second.get();
56 else 56 else
57 return NULL; 57 return NULL;
58 } 58 }
59 59
60 } // namespace extensions 60 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698