Add new filter repaint test for turbulence, rebaseline existing test

Add new filter repaint test for turbulence, rebaseline existing test

This patch adds a new (currently failing) filter repaint test to show
how we improperly repaint turbulence filters. In addition, the existing
test for 640264 has been unskipped and rebaselined with a failing
result. These two changes should help catch progressions in the future.

BUG=598051, 640264
Committed: https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020
Cr-Commit-Position: refs/heads/master@{#415363}

[pdr., 2016-08-29 23:10:38]

pdr@chromium.org changed reviewers:
+ senorblanco@chromium.org, wkorman@chromium.org

[pdr., 2016-08-29 23:11:05]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[pdr., 2016-08-29 23:21:54]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 02:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:43:40]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-08-30 13:50:15]

https://codereview.chromium.org/2294633002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2294633002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:574: crbug.com/640264
fast/repaint/turbulence-filter-repaint.html [ NeedsRebaseline ]
Could you move this to css3/filters? There are a bunch of repaint tests 
there as effect-reference-repaint-foo.html. You could also rewrite it in 
the form of those tests if you like (or not, not a big deal). They do 
have reftest results, which is kind of nice.

[pdr., 2016-08-30 16:45:39]

PTAL

https://codereview.chromium.org/2294633002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2294633002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:574: crbug.com/640264
fast/repaint/turbulence-filter-repaint.html [ NeedsRebaseline ]
On 2016/08/30 at 13:50:15, Stephen White wrote:
> Could you move this to css3/filters? There are a bunch of repaint tests 
> there as effect-reference-repaint-foo.html. You could also rewrite it in 
> the form of those tests if you like (or not, not a big deal). They do 
> have reftest results, which is kind of nice.

Done, I've rewritten the test as css3/filters/filter-repaint-turbulence.html. I
think the text+pixel results (testRunner.dumpAsTextWithPixelResults()) will be
useful for this test because it shows where the underinvalidation occurs. I can
switch it to just be text output if you'd like though.

[Stephen White, 2016-08-30 17:05:51]

LGTM. Thanks!

https://codereview.chromium.org/2294633002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2294633002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:574: crbug.com/640264
fast/repaint/turbulence-filter-repaint.html [ NeedsRebaseline ]
On 2016/08/30 16:45:39, pdr. wrote:
> On 2016/08/30 at 13:50:15, Stephen White wrote:
> > Could you move this to css3/filters? There are a bunch of repaint tests 
> > there as effect-reference-repaint-foo.html. You could also rewrite it in 
> > the form of those tests if you like (or not, not a big deal). They do 
> > have reftest results, which is kind of nice.
> 
> Done, I've rewritten the test as css3/filters/filter-repaint-turbulence.html.
I
> think the text+pixel results (testRunner.dumpAsTextWithPixelResults()) will be
> useful for this test because it shows where the underinvalidation occurs. I
can
> switch it to just be text output if you'd like though.

Sounds good. We can always flip it over to text-only when it's fixed.

[pdr., 2016-08-30 17:06:24]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:06:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:28:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 18:29:33]

Description was changed from

==========
Add new filter repaint test for turbulence, rebaseline existing test

This patch adds a new (currently failing) filter repaint test to show
how we improperly repaint turbulence filters. In addition, the existing
test for 640264 has been unskipped and rebaselined with a failing
result. These two changes should help catch progressions in the future.

BUG=598051,640264
==========

to

==========
Add new filter repaint test for turbulence, rebaseline existing test

This patch adds a new (currently failing) filter repaint test to show
how we improperly repaint turbulence filters. In addition, the existing
test for 640264 has been unskipped and rebaselined with a failing
result. These two changes should help catch progressions in the future.

BUG=598051,640264

Committed: https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020
Cr-Commit-Position: refs/heads/master@{#415363}
==========

[commit-bot: I haz the power, 2016-08-30 18:29:34]

Patchset 4 (id:??) landed as
https://crrev.com/e465f9c7e83038547530b26bd26c432726a11020
Cr-Commit-Position: refs/heads/master@{#415363}

[yhirano, 2016-08-31 01:01:38]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2298033002/ by yhirano@chromium.org.

The reason for reverting is: css3/filters/filter-repaint-turbulence.html is
failing on Linux (dbg), WebKit Mac10.11 (dbg) and WebKit Win7 (dbg).

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg....

[yhirano, 2016-08-31 01:39:56]

On 2016/08/31 01:01:38, yhirano wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2298033002/ by mailto:yhirano@chromium.org.
> 
> The reason for reverting is: css3/filters/filter-repaint-turbulence.html is
> failing on Linux (dbg), WebKit Mac10.11 (dbg) and WebKit Win7 (dbg).
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg....

I failed to revert this CL due to the rebaseline bot. Instead I am adding the
failed test to TestExpectations. https://codereview.chromium.org/2289123004/

[pdr., 2016-08-31 02:33:43]

On 2016/08/31 at 01:39:56, yhirano wrote:
> On 2016/08/31 01:01:38, yhirano wrote:
> > A revert of this CL (patchset #4 id:60001) has been created in
> > https://codereview.chromium.org/2298033002/ by mailto:yhirano@chromium.org.
> > 
> > The reason for reverting is: css3/filters/filter-repaint-turbulence.html is
> > failing on Linux (dbg), WebKit Mac10.11 (dbg) and WebKit Win7 (dbg).
> > 
> >
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg....
> 
> I failed to revert this CL due to the rebaseline bot. Instead I am adding the
failed test to TestExpectations. https://codereview.chromium.org/2289123004/

Thanks yhirano, it looks like this fails on debug only which wasn't caught by
the CQ.