Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229463003: MacOS implementation of BluetoothSocket. (Closed)

Created:
6 years, 8 months ago by rpaquay
Modified:
6 years, 8 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Visibility:
Public.

Description

MacOS implementation of BluetoothSocket. BUG=343725, 343651 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263018

Patch Set 1 #

Patch Set 2 : Fix build error on OSX SDK < 10.7. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -149 lines) Patch
M device/bluetooth/bluetooth_adapter_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 2 chunks +9 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 5 chunks +11 lines, -11 lines 0 comments Download
M device/bluetooth/bluetooth_profile_mac.h View 2 chunks +13 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_profile_mac.mm View 1 3 chunks +96 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_socket_mac.h View 4 chunks +81 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_socket_mac.mm View 2 chunks +314 lines, -99 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rpaquay
This is the MacOS implementation of BluetoothSocket. Note all I/O operations are performed in the ...
6 years, 8 months ago (2014-04-08 23:49:43 UTC) #1
keybuk
lgtm
6 years, 8 months ago (2014-04-09 22:16:16 UTC) #2
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 8 months ago (2014-04-09 23:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/229463003/1
6 years, 8 months ago (2014-04-09 23:48:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 01:13:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-10 01:13:54 UTC) #6
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 8 months ago (2014-04-10 15:13:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/229463003/20001
6 years, 8 months ago (2014-04-10 15:13:50 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 17:09:56 UTC) #9
Message was sent while issue was closed. 
Change committed as 263018

Powered by Google App Engine
This is Rietveld 408576698