Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2294613002: MD Downloads/History: Fix CSS selector that was mistakenly LTR-only (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads/History: Fix CSS selector that was mistakenly LTR-only This fixes incorrect padding in the toolbar search field for RTL languages. BUG=642169 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fe32a27d5519cfeec388333ebc091af07a58c8b1 Cr-Commit-Position: refs/heads/master@{#415206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
4 years, 3 months ago (2016-08-29 23:07:39 UTC) #4
Dan Beam
now we're going in the right direction! lgtm
4 years, 3 months ago (2016-08-29 23:31:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294613002/1
4 years, 3 months ago (2016-08-30 03:52:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:13:04 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:15:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe32a27d5519cfeec388333ebc091af07a58c8b1
Cr-Commit-Position: refs/heads/master@{#415206}

Powered by Google App Engine
This is Rietveld 408576698