Added WATCHLISTS definition filesapp for Files App related changes.

Added WATCHLISTS definition filesapp for Files App related changes.

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using ~/depot_tools/watchlists.py.

Committed: https://crrev.com/b0be3dce2301f38867582ade045191f5697ff9f6
Cr-Commit-Position: refs/heads/master@{#415233}

[oka, 2016-08-30 05:15:13]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-08-30 05:15:14]

PTAL.

[oka, 2016-08-30 05:18:40]

fix

[oka, 2016-08-30 05:32:57]

fix

[oka, 2016-08-30 05:34:21]

Remove needless files.

[oka, 2016-08-30 05:37:20]

Description was changed from

==========
Make chromeos-files-app-watch@google.com watch Files App related changes.

BUG=None
Test=None
==========

to

==========
Added WATCHLIST definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=Ran the following commands and confirmed oka+watch@chromium.org appears in
the list.
~/depot_tools/watchlists.py ui/file_manager/file_manager/main.html 
~/depot_tools/watchlists.py chrome/browser/chromeos/drive/
~/depot_tools/watchlists.py chrome/browser/chromeos/file_manager/
~/depot_tools/watchlists.py chrome/browser/chromeos/extensions/file_manager/
==========

[oka, 2016-08-30 05:37:31]

PTAL.

[fukino, 2016-08-30 05:49:16]

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS#newcode434
WATCHLISTS:434: 'filesapp_all': {
It looks a bit weird to have 'filesapp' and 'filesapp_all'. Combine them into
one 'filesapp', or having 'filesapp_ui' and 'filesapp' makes more sense to me.

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS#newcode435
WATCHLISTS:435: 'filepath': 'chrome/browser/chromeos/drive|' \
filesapp_all looks missing some directories compared to
https://sites.google.com/a/google.com/chromeos-team-tok/files-app/how-big-is-...

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS#newcode436
WATCHLISTS:436: 'chrome/browser/chromeos/extensions/file_manager|'
'\' is missing at the end of line.
(testing watchlists.py should have detected it?)

[oka, 2016-08-30 06:06:58]

Address comments.

[oka, 2016-08-30 06:08:51]

PTALA

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS#newcode434
WATCHLISTS:434: 'filesapp_all': {
On 2016/08/30 05:49:16, fukino wrote:
> It looks a bit weird to have 'filesapp' and 'filesapp_all'. Combine them into
> one 'filesapp', or having 'filesapp_ui' and 'filesapp' makes more sense to me.

Done.

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS#newcode435
WATCHLISTS:435: 'filepath': 'chrome/browser/chromeos/drive|' \
On 2016/08/30 05:49:16, fukino wrote:
> filesapp_all looks missing some directories compared to
>
https://sites.google.com/a/google.com/chromeos-team-tok/files-app/how-big-is-...

Done.

https://codereview.chromium.org/2294603003/diff/60001/WATCHLISTS#newcode436
WATCHLISTS:436: 'chrome/browser/chromeos/extensions/file_manager|'
On 2016/08/30 05:49:16, fukino wrote:
> '\' is missing at the end of line.
> (testing watchlists.py should have detected it?)

Done. I sorted the lines but forgot to run test after that.

[oka, 2016-08-30 06:10:01]

Description was changed from

==========
Added WATCHLIST definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=Ran the following commands and confirmed oka+watch@chromium.org appears in
the list.
~/depot_tools/watchlists.py ui/file_manager/file_manager/main.html 
~/depot_tools/watchlists.py chrome/browser/chromeos/drive/
~/depot_tools/watchlists.py chrome/browser/chromeos/file_manager/
~/depot_tools/watchlists.py chrome/browser/chromeos/extensions/file_manager/
==========

to

==========
Added WATCHLIST definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed for all directories oka+watch@ appears in watchlist using
~/depot_tools/watchlists.py.
==========

[oka, 2016-08-30 06:10:46]

Description was changed from

==========
Added WATCHLIST definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed for all directories oka+watch@ appears in watchlist using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLIST definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[oka, 2016-08-30 06:10:56]

Description was changed from

==========
Added WATCHLIST definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[oka, 2016-08-30 06:11:26]

Description was changed from

==========
Added WATCHLISTS definition filesapp_all for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[oka, 2016-08-30 06:11:38]

Description was changed from

==========
Added WATCHLISTS definition filesapp for File App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[oka, 2016-08-30 06:11:51]

Description was changed from

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made oka+watch@chromium.org watch filesapp_all.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made oka+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[fukino, 2016-08-30 06:29:17]

lgtm with a request. Thanks!

https://codereview.chromium.org/2294603003/diff/80001/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2294603003/diff/80001/WATCHLISTS#newcode1748
WATCHLISTS:1748: 'filesapp': ['oka+watch@chromium.org'],
Could you add fukino+watch@chromium.org too?

[oka, 2016-08-30 06:43:04]

Add fukino and yamaguchi.

[oka, 2016-08-30 06:44:50]

sort

[oka, 2016-08-30 06:45:22]

The CQ bit was checked by oka@chromium.org

[oka, 2016-08-30 06:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2294603003/#ps120001
(title: "sort")

[commit-bot: I haz the power, 2016-08-30 06:45:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-08-30 06:49:47]

Description was changed from

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made oka+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[commit-bot: I haz the power, 2016-08-30 07:37:26]

Description was changed from

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

[commit-bot: I haz the power, 2016-08-30 07:37:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-30 07:38:39]

Description was changed from

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.
==========

to

==========
Added WATCHLISTS definition filesapp for Files App related changes.

And made {fukino,oka,yamaguchi}+watch@chromium.org watch filesapp.

BUG=None
Test=I confirmed oka+watch@ appears in watchlist of all the directories using
~/depot_tools/watchlists.py.

Committed: https://crrev.com/b0be3dce2301f38867582ade045191f5697ff9f6
Cr-Commit-Position: refs/heads/master@{#415233}
==========

[commit-bot: I haz the power, 2016-08-30 07:38:40]

Patchset 7 (id:??) landed as
https://crrev.com/b0be3dce2301f38867582ade045191f5697ff9f6
Cr-Commit-Position: refs/heads/master@{#415233}