Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2294563002: MD WebUI (History, Settings, Downloads): autofocus big search box (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI (History, Settings, Downloads): autofocus big search box R=tsergeant@chromium.org BUG=641929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/052d75ad9755e63a894c519509360d121d837cb4 Cr-Commit-Position: refs/heads/master@{#415083}

Patch Set 1 #

Patch Set 2 : vulcanize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
note: all current/old webui pages seemed to autofocus their respective search inputs
4 years, 3 months ago (2016-08-29 20:54:09 UTC) #2
tsergeant
lgtm. FYI, the autofocus doesn't do anything in History due to load order weirdness, so ...
4 years, 3 months ago (2016-08-29 22:50:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294563002/20001
4 years, 3 months ago (2016-08-30 02:18:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 04:17:09 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:18:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/052d75ad9755e63a894c519509360d121d837cb4
Cr-Commit-Position: refs/heads/master@{#415083}

Powered by Google App Engine
This is Rietveld 408576698