Issue 2294553002: Revert "Use ->() in CPDF_ColorState"

Issue 2294553002: Revert "Use ->() in CPDF_ColorState" (Closed)

Created:
4 years, 3 months ago by Tom Sepez

Modified:
4 years, 3 months ago

Reviewers:
dsinclair

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Revert "Use ->() in CPDF_ColorState" This reverts commit 91ddd3f7501429222f648b986a99f3959a398889. Reason for revert: may introduce sublte bugs, more thought required. TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/adbd32950006075fc04ff2cbb01bf3a099f0e010

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+193 lines, -187 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/fpdfapi/fpdf_page/cpdf_colorstate.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	core/fpdfapi/fpdf_page/cpdf_colorstate.cpp	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	core/fpdfapi/fpdf_page/cpdf_colorstatedata.h	View	1 chunk	+3 lines, -35 lines	0 comments	Download
M	core/fpdfapi/fpdf_page/cpdf_colorstatedata.cpp	View	1 chunk	+5 lines, -69 lines	0 comments	Download
M	core/fpdfapi/fpdf_page/cpdf_graphicstates.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/fpdf_page/fpdf_page_parser.cpp	View	11 chunks	+40 lines, -47 lines	0 comments	Download
M	core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/fpdf_render/fpdf_render.cpp	View	4 chunks	+22 lines, -23 lines	0 comments	Download
M	core/fpdfapi/fpdf_render/fpdf_render_image.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/fpdfapi/fpdf_render/fpdf_render_text.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/fxedit/fxet_edit.cpp	View	2 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 6 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294553002/1

4 years, 3 months ago (2016-08-29 20:43:55 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-08-29 21:08:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/adbd32950006075fc04ff2cbb01bf3a099f0...