Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229453004: Rename VideoFrame::{Get,Set}Timestamp() to {set_}timestamp(). (Closed)

Created:
6 years, 8 months ago by scherkus (not reviewing)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Rename VideoFrame::{Get,Set}Timestamp() to {set_}timestamp(). Makes the naming consistent with AudioBuffer, which is helpful now that DecoderStream<T> enforces API consistency. TBR=dmichael Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262914

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fix compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/rtc_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_source_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_video_sink_adapter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_video_source_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/skcanvas_video_renderer_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/filters/video_renderer_impl.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M media/filters/video_renderer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
scherkus (not reviewing)
6 years, 8 months ago (2014-04-09 01:26:03 UTC) #1
scherkus (not reviewing)
(I was trying to add some TRACE macros based on the timestamp value, and DecoderStream ...
6 years, 8 months ago (2014-04-09 01:27:24 UTC) #2
DaleCurtis
lgtm
6 years, 8 months ago (2014-04-09 17:26:56 UTC) #3
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-09 17:28:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/229453004/1
6 years, 8 months ago (2014-04-09 17:29:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 18:11:46 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60403
6 years, 8 months ago (2014-04-09 18:11:47 UTC) #7
scherkus (not reviewing)
TBR=dmichael for content/renderer/pepper/*
6 years, 8 months ago (2014-04-09 20:37:12 UTC) #8
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-09 20:40:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/229453004/20001
6 years, 8 months ago (2014-04-09 20:42:43 UTC) #10
dmichael (off chromium)
pepper lgtm
6 years, 8 months ago (2014-04-09 20:54:26 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 22:32:51 UTC) #12
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=64229
6 years, 8 months ago (2014-04-09 22:32:51 UTC) #13
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-09 22:41:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/229453004/40001
6 years, 8 months ago (2014-04-09 22:41:54 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 23:43:35 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-09 23:43:35 UTC) #17
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 8 months ago (2014-04-10 00:20:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/229453004/80001
6 years, 8 months ago (2014-04-10 00:22:06 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 04:51:26 UTC) #20
Message was sent while issue was closed. 
Change committed as 262914

Powered by Google App Engine
This is Rietveld 408576698