Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2294513002: Spell dbg lld win bot names correctly in json file listing tests. (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Spell dbg lld win bot names correctly in json file listing tests. The debug bots have strange names due to path name limitations. I got this wrong in https://codereview.chromium.org/1948593003/ I happened to notice that 'cause tests currently fail on 32-bit LLD builds, but the debug 32-bit bot was happy when it shouldn't have been. BUG=642027 R=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/781204305cdc8bb696fb9b068b03cbd3d1b51a26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Nico
4 years, 3 months ago (2016-08-29 18:54:45 UTC) #4
hans
lgtm
4 years, 3 months ago (2016-08-29 19:31:19 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/781204305cdc8bb696fb9b068b03cbd3d1b51a26 Cr-Commit-Position: refs/heads/master@{#415026}
4 years, 3 months ago (2016-08-29 19:48:35 UTC) #8
Nico
4 years, 3 months ago (2016-08-29 19:50:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
781204305cdc8bb696fb9b068b03cbd3d1b51a26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698