Clicking on the HaTS notification now opens the survey dialog

Clicking on the HaTS notification now opens the survey dialog

BUG=642078
COMPONENT=HaTS, Chrome OS

Committed: https://crrev.com/740cb043e9dbcb63683f0c1887ae43f239b3a99e
Cr-Commit-Position: refs/heads/master@{#415357}

[malaykeshav, 2016-08-30 00:23:46]

malaykeshav@chromium.org changed reviewers:
+ jdufault@chromium.org, stevenjb@chromium.org

[malaykeshav, 2016-08-30 00:23:47]

PTAL

[malaykeshav, 2016-08-30 00:23:54]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[jdufault, 2016-08-30 00:30:29]

On 2016/08/30 00:23:47, malaykeshav wrote:
> PTAL

lgtm

[commit-bot: I haz the power, 2016-08-30 02:18:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:43:34]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-08-30 15:39:16]

lgtm

https://codereview.chromium.org/2294473003/diff/1/chrome/browser/chromeos/hat...
File chrome/browser/chromeos/hats/hats_notification_controller.cc (right):

https://codereview.chromium.org/2294473003/diff/1/chrome/browser/chromeos/hat...
chrome/browser/chromeos/hats/hats_notification_controller.cc:184: ButtonClick(0
/* This argument is no-op in the function. */);
nit: ButtonClick(0 /* unused */);

https://codereview.chromium.org/2294473003/diff/1/chrome/browser/chromeos/hat...
chrome/browser/chromeos/hats/hats_notification_controller.cc:188: void
HatsNotificationController::ButtonClick(int button_index) {
nit: int /* button_index */

[malaykeshav, 2016-08-30 17:26:26]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 17:26:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 18:07:55]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-08-30 18:09:30]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-08-30 18:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2294473003/#ps20001
(title: "Clicking HaTS notification now opens the survey dialog")

[commit-bot: I haz the power, 2016-08-30 18:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-08-30 18:10:30]

https://codereview.chromium.org/2294473003/diff/1/chrome/browser/chromeos/hat...
File chrome/browser/chromeos/hats/hats_notification_controller.cc (right):

https://codereview.chromium.org/2294473003/diff/1/chrome/browser/chromeos/hat...
chrome/browser/chromeos/hats/hats_notification_controller.cc:184: ButtonClick(0
/* This argument is no-op in the function. */);
On 2016/08/30 at 15:39:16, stevenjb wrote:
> nit: ButtonClick(0 /* unused */);

done

https://codereview.chromium.org/2294473003/diff/1/chrome/browser/chromeos/hat...
chrome/browser/chromeos/hats/hats_notification_controller.cc:188: void
HatsNotificationController::ButtonClick(int button_index) {
On 2016/08/30 at 15:39:16, stevenjb wrote:
> nit: int /* button_index */

done

[commit-bot: I haz the power, 2016-08-30 18:15:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 18:19:08]

Description was changed from

==========
Clicking on the HaTS notification now opens the survey dialog

BUG=642078
COMPONENT=HaTS, Chrome OS
==========

to

==========
Clicking on the HaTS notification now opens the survey dialog

BUG=642078
COMPONENT=HaTS, Chrome OS

Committed: https://crrev.com/740cb043e9dbcb63683f0c1887ae43f239b3a99e
Cr-Commit-Position: refs/heads/master@{#415357}
==========

[commit-bot: I haz the power, 2016-08-30 18:19:09]

Patchset 2 (id:??) landed as
https://crrev.com/740cb043e9dbcb63683f0c1887ae43f239b3a99e
Cr-Commit-Position: refs/heads/master@{#415357}