s/s_fontManager/s_staticFontManager/ to help rewrite_to_chrome_style tool.

s/s_fontManager/s_staticFontManager/ to help rewrite_to_chrome_style tool.

This CL helps rewrite_to_chrome_style tool, by preventing the tool for
suggesting the following conflicting renames:
- |s_field| -> |field_|
- |m_field| -> |field_|

BUG=641004
Committed: https://crrev.com/78115b26dfafd0fca676ac33caabd3aa8b43ecf4
Cr-Commit-Position: refs/heads/master@{#415058}

[Łukasz Anforowicz, 2016-08-29 20:45:15]

lukasza@chromium.org changed reviewers:
+ tkent@chromium.org

[Łukasz Anforowicz, 2016-08-29 20:45:16]

tkent@, could you please take a look?

[tkent, 2016-08-29 20:59:50]

lgtm

[Łukasz Anforowicz, 2016-08-29 21:09:02]

The CQ bit was checked by lukasza@chromium.org

[dcheng, 2016-08-29 21:11:02]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-08-29 21:11:02]

Another potential way to solve this is to just use a prefix I guess. Does
Chromium have any convention of doing this? It looks like we do it

[danakj, 2016-08-29 21:12:48]

On Mon, Aug 29, 2016 at 2:11 PM, <dcheng@chromium.org> wrote:

> Another potential way to solve this is to just use a prefix I guess. Does
> Chromium have any convention of doing this? It looks like we do it
>

The style guide says to not prefix static variables, I don't think this
needs an exception.


>
> https://codereview.chromium.org/2294433002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-08-29 21:20:45]

On Mon, Aug 29, 2016 at 2:11 PM, <dcheng@chromium.org> wrote:

> Another potential way to solve this is to just use a prefix I guess. Does
> Chromium have any convention of doing this? It looks like we do it
>

The style guide says to not prefix static variables, I don't think this
needs an exception.


>
> https://codereview.chromium.org/2294433002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-08-30 02:18:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:49:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 03:52:51]

Description was changed from

==========
s/s_fontManager/s_staticFontManager/ to help rewrite_to_chrome_style tool.

This CL helps rewrite_to_chrome_style tool, by preventing the tool for
suggesting the following conflicting renames:
- |s_field| -> |field_|
- |m_field| -> |field_|

BUG=641004
==========

to

==========
s/s_fontManager/s_staticFontManager/ to help rewrite_to_chrome_style tool.

This CL helps rewrite_to_chrome_style tool, by preventing the tool for
suggesting the following conflicting renames:
- |s_field| -> |field_|
- |m_field| -> |field_|

BUG=641004

Committed: https://crrev.com/78115b26dfafd0fca676ac33caabd3aa8b43ecf4
Cr-Commit-Position: refs/heads/master@{#415058}
==========

[commit-bot: I haz the power, 2016-08-30 03:52:52]

Patchset 1 (id:??) landed as
https://crrev.com/78115b26dfafd0fca676ac33caabd3aa8b43ecf4
Cr-Commit-Position: refs/heads/master@{#415058}