Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: scripts/slave/recipes/run_presubmit.py

Issue 2294423002: Remove gerrit_rebase_patch_ref from run_presubmit.py (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'depot_tools/bot_update', 6 'depot_tools/bot_update',
7 'depot_tools/gclient', 7 'depot_tools/gclient',
8 'depot_tools/git', 8 'depot_tools/git',
9 'depot_tools/presubmit', 9 'depot_tools/presubmit',
10 'recipe_engine/json', 10 'recipe_engine/json',
(...skipping 10 matching lines...) Expand all
21 21
22 def _RunStepsInternal(api): 22 def _RunStepsInternal(api):
23 repo_name = api.properties['repo_name'] 23 repo_name = api.properties['repo_name']
24 codereview_auth = api.properties.get('codereview_auth', False) 24 codereview_auth = api.properties.get('codereview_auth', False)
25 force_checkout = api.properties.get('force_checkout', False) 25 force_checkout = api.properties.get('force_checkout', False)
26 patch_storage = api.properties.get('patch_storage', 'rietveld') 26 patch_storage = api.properties.get('patch_storage', 'rietveld')
27 27
28 api.gclient.set_config(repo_name) 28 api.gclient.set_config(repo_name)
29 29
30 kwargs = {} 30 kwargs = {}
31 if patch_storage == 'gerrit':
32 kwargs['gerrit_rebase_patch_ref'] = True
33 bot_update_step = api.bot_update.ensure_checkout( 31 bot_update_step = api.bot_update.ensure_checkout(
34 force=force_checkout, 32 force=force_checkout,
35 patch_oauth2=codereview_auth, 33 patch_oauth2=codereview_auth,
36 **kwargs) 34 **kwargs)
37 relative_root = api.gclient.calculate_patch_root( 35 relative_root = api.gclient.calculate_patch_root(
38 api.properties['patch_project']).rstrip('/') 36 api.properties['patch_project']).rstrip('/')
39 got_revision_property = api.gclient.c.got_revision_mapping[relative_root] 37 got_revision_property = api.gclient.c.got_revision_mapping[relative_root]
40 upstream = bot_update_step.json.output['properties'].get( 38 upstream = bot_update_step.json.output['properties'].get(
41 got_revision_property) 39 got_revision_property)
42 40
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 215
218 yield ( 216 yield (
219 api.test('presubmit-infra-failure') + 217 api.test('presubmit-infra-failure') +
220 api.properties.tryserver( 218 api.properties.tryserver(
221 mastername='tryserver.chromium.linux', 219 mastername='tryserver.chromium.linux',
222 buildername='chromium_presubmit', 220 buildername='chromium_presubmit',
223 repo_name='chromium', 221 repo_name='chromium',
224 patch_project='chromium') + 222 patch_project='chromium') +
225 api.step_data('presubmit', api.json.output({}, retcode=2)) 223 api.step_data('presubmit', api.json.output({}, retcode=2))
226 ) 224 )
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698