bot_update: add --auth-refresh-token-json passthrough for apply_issue

bot_update: add --auth-refresh-token-json passthrough for apply_issue

BUG=642150
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e465667e78b3f898f25b64a3ec4f5c003f7554e7

[Ryan Tseng, 2016-08-31 20:30:31]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 20:30:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-08-31 20:30:45]

Description was changed from

==========
bot_update: add --auth-refresh-token-json passthrough for apply_issue

BUG=
==========

to

==========
bot_update: add --auth-refresh-token-json passthrough for apply_issue

BUG=642150
==========

[commit-bot: I haz the power, 2016-08-31 20:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:44:07]

Dry run: This issue passed the CQ dry run.

[Ryan Tseng, 2016-08-31 21:26:29]

hinoka@google.com changed reviewers:
+ tandrii@chromium.org, vadimsh@chromium.org

[Ryan Tseng, 2016-08-31 21:26:29]

ptal, in this CL, the caller sets the location for the credentials file.  Which
is different than the previous behavior.  Should the recipe module just know
about the credential file location instead?

[Ryan Tseng, 2016-08-31 21:27:10]

hinoka@google.com changed reviewers:
+ martiniss@chromium.org
- tandrii@chromium.org

[Ryan Tseng, 2016-08-31 21:27:34]

+martiniss because he was involved in the other piece of
inject-key-file-into-apply-issue code

[Vadim Sh., 2016-08-31 22:02:24]

I believe it's better to be explicit about this stuff. It removes the element of
surprise when deploying new builders.

Unless it would be very difficult to pass this flag from the corresponding
tryjob recipe.

https://codereview.chromium.org/2294413002/diff/1/recipe_modules/bot_update/a...
File recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/2294413002/diff/1/recipe_modules/bot_update/a...
recipe_modules/bot_update/api.py:152: email_file =
'/creds/rietveld/client_email'
please make email_file and key_file None if oauth2_file is used.

[Ryan Tseng, 2016-08-31 22:20:21]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:20:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:26:37]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30fb82178f4abf10)

[Ryan Tseng, 2016-08-31 22:39:19]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:45:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:45:32]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30fb9363ce98df10)

[tandrii(chromium), 2016-09-01 15:49:32]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-09-01 15:49:34]

lgtm

https://codereview.chromium.org/2294413002/diff/40001/recipe_modules/bot_upda...
File recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/2294413002/diff/40001/recipe_modules/bot_upda...
recipe_modules/bot_update/api.py:149: elif patch_oauth2:
since oauth2_json takes patch_oauth2, i'd add to top level 

assert not (oauth2_json and patch_oauth2)

[Ryan Tseng, 2016-09-19 18:59:20]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 18:59:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-09-19 19:01:27]

https://codereview.chromium.org/2294413002/diff/1/recipe_modules/bot_update/a...
File recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/2294413002/diff/1/recipe_modules/bot_update/a...
recipe_modules/bot_update/api.py:152: email_file =
'/creds/rietveld/client_email'
On 2016/08/31 22:02:24, Vadim Sh. wrote:
> please make email_file and key_file None if oauth2_file is used.

Done.

https://codereview.chromium.org/2294413002/diff/40001/recipe_modules/bot_upda...
File recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/2294413002/diff/40001/recipe_modules/bot_upda...
recipe_modules/bot_update/api.py:149: elif patch_oauth2:
On 2016/09/01 15:49:33, tandrii(chromium) wrote:
> since oauth2_json takes patch_oauth2, i'd add to top level 
> 
> assert not (oauth2_json and patch_oauth2)

Done.

[Ryan Tseng, 2016-09-19 19:02:32]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-09-19 19:04:30]

LGTM % retrain expectations.

https://codereview.chromium.org/2294413002/diff/60001/recipe_modules/bot_upda...
File recipe_modules/bot_update/example.expected/trychange_oauth2_json.json
(right):

https://codereview.chromium.org/2294413002/diff/60001/recipe_modules/bot_upda...
recipe_modules/bot_update/example.expected/trychange_oauth2_json.json:7:
"--master",
retrain expectations.

[Ryan Tseng, 2016-09-19 19:04:38]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:04:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Tseng, 2016-09-19 19:06:35]

The CQ bit was unchecked by hinoka@google.com

[Ryan Tseng, 2016-09-19 19:06:37]

The CQ bit was checked by hinoka@google.com

[Ryan Tseng, 2016-09-19 19:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2294413002/#ps100001
(title: "Retrain recipes")

[commit-bot: I haz the power, 2016-09-19 19:06:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:10:56]

Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/315ca9925081d710)

[Ryan Tseng, 2016-09-19 19:13:14]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:17:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:17:55]

Dry run: Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/315cb1d10602dc10)

[Ryan Tseng, 2016-09-19 19:38:14]

The CQ bit was checked by hinoka@google.com

[Ryan Tseng, 2016-09-19 19:38:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/2294413002/#ps120001
(title: "More coverage")

[commit-bot: I haz the power, 2016-09-19 19:38:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:42:40]

Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/315cc69109442b10)

[Ryan Tseng, 2016-09-19 22:24:57]

The CQ bit was checked by hinoka@google.com

[commit-bot: I haz the power, 2016-09-19 22:25:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 22:28:22]

Description was changed from

==========
bot_update: add --auth-refresh-token-json passthrough for apply_issue

BUG=642150
==========

to

==========
bot_update: add --auth-refresh-token-json passthrough for apply_issue

BUG=642150

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e465667e78b3f8...
==========

[commit-bot: I haz the power, 2016-09-19 22:28:23]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e465667e78b3f8...

[Ryan Tseng, 2016-09-20 01:08:23]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2350363003/ by hinoka@google.com.

The reason for reverting is: Pointing to the wrong file :(.