Implementation of the "Redirect URLs to Packaged Apps" feature.

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 48 matching lines @@
 #include "content/browser/in_process_webkit/indexed_db_dispatcher_host.h"
 #include "content/browser/indexed_db/indexed_db_context_impl.h"
 #include "content/browser/loader/resource_message_filter.h"
 #include "content/browser/loader/resource_scheduler_filter.h"
 #include "content/browser/media/media_internals.h"
 #include "content/browser/mime_registry_message_filter.h"
 #include "content/browser/plugin_service_impl.h"
 #include "content/browser/profiler_message_filter.h"
 #include "content/browser/renderer_host/clipboard_message_filter.h"
 #include "content/browser/renderer_host/database_message_filter.h"
+#include "content/browser/renderer_host/extension_system_message_filter.h"
 #include "content/browser/renderer_host/file_utilities_message_filter.h"
 #include "content/browser/renderer_host/gamepad_browser_message_filter.h"
 #include "content/browser/renderer_host/gpu_message_filter.h"
 #include "content/browser/renderer_host/media/audio_input_renderer_host.h"
 #include "content/browser/renderer_host/media/audio_mirroring_manager.h"
 #include "content/browser/renderer_host/media/audio_renderer_host.h"
 #include "content/browser/renderer_host/media/media_stream_dispatcher_host.h"
 #include "content/browser/renderer_host/media/peer_connection_tracker_host.h"
 #include "content/browser/renderer_host/media/video_capture_host.h"
 #include "content/browser/renderer_host/p2p/socket_dispatcher_host.h"
@@ skipping 22 matching lines @@
 #include "content/port/browser/render_widget_host_view_frame_subscriber.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host_factory.h"
 #include "content/public/browser/resource_context.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
+#include "content/public/common/extension_system_messages.h"
 #include "content/public/common/process_type.h"
 #include "content/public/common/result_codes.h"
 #include "content/public/common/url_constants.h"
 #include "content/renderer/render_process_impl.h"
 #include "content/renderer/render_thread_impl.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_logging.h"
 #include "ipc/ipc_platform_file.h"
 #include "ipc/ipc_switches.h"
 #include "ipc/ipc_sync_channel.h"
@@ skipping 413 matching lines @@
 
     fast_shutdown_started_ = false;
   }
 
   is_initialized_ = true;
   return true;
 }
 
 void RenderProcessHostImpl::CreateMessageFilters() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  // ResourceSchedulerFilter

[Charlie Reis, 2013/08/26 22:17:52]

My sense is that these comments aren't really adding much beyond the code
itself, since they're just repeating what each line says.  I could see a use for
them if there were larger chunks of code being categorized, but almost all of
these are just one line or one block.  I'd suggest leaving them out.

[sergeygs, 2013/08/29 08:24:42]

I'd say that it was rather hard to quickly enumerate filters being added just by
looking at the original code, which wasn't even whitespace-separated to aid
that, but I've removed the comments per your suggestion.

On 2013/08/26 22:17:52, creis wrote:

   channel_->AddFilter(new ResourceSchedulerFilter(GetID()));
-  MediaInternals* media_internals = MediaInternals::GetInstance();;
+
+  MediaInternals* media_internals = MediaInternals::GetInstance();
+
   // Add BrowserPluginMessageFilter to ensure it gets the first stab at messages
   // from guests.
   if (supports_browser_plugin_) {
     scoped_refptr<BrowserPluginMessageFilter> bp_message_filter(
         new BrowserPluginMessageFilter(GetID(), IsGuest()));
     channel_->AddFilter(bp_message_filter);
   }
 
+  // RenderMessageFilter
   scoped_refptr<RenderMessageFilter> render_message_filter(
       new RenderMessageFilter(
           GetID(),
 #if defined(ENABLE_PLUGINS)
           PluginServiceImpl::GetInstance(),
 #else
           NULL,
 #endif
           GetBrowserContext(),
           GetBrowserContext()->GetRequestContextForRenderProcess(GetID()),
           widget_helper_,
           media_internals,
           storage_partition_impl_->GetDOMStorageContext()));
   channel_->AddFilter(render_message_filter);
+
   BrowserContext* browser_context = GetBrowserContext();
+
+  // ResourceMessageFilter
   ResourceContext* resource_context = browser_context->GetResourceContext();
-
   ResourceMessageFilter* resource_message_filter = new ResourceMessageFilter(
       GetID(), PROCESS_TYPE_RENDERER, resource_context,
       storage_partition_impl_->GetAppCacheService(),
       ChromeBlobStorageContext::GetFor(browser_context),
       storage_partition_impl_->GetFileSystemContext(),
       new RendererURLRequestContextSelector(browser_context, GetID()));
+  channel_->AddFilter(resource_message_filter);
 
-  channel_->AddFilter(resource_message_filter);
+  // AudioInputRendererHost and AudioRendererHost
   media::AudioManager* audio_manager = BrowserMainLoop::GetAudioManager();
   MediaStreamManager* media_stream_manager =
       BrowserMainLoop::GetMediaStreamManager();
   channel_->AddFilter(new AudioInputRendererHost(audio_manager,
                                                  media_stream_manager));
   channel_->AddFilter(new AudioRendererHost(
       GetID(), audio_manager, BrowserMainLoop::GetAudioMirroringManager(),
       media_internals));
+
+  // VideoCaptureHost
   channel_->AddFilter(new VideoCaptureHost());
+
+  // AppCacheDispatcherHost
   channel_->AddFilter(new AppCacheDispatcherHost(
       storage_partition_impl_->GetAppCacheService(),
       GetID()));
+
+  // ClipboardMessageFilter
   channel_->AddFilter(new ClipboardMessageFilter(browser_context));
+
+  // DOMStorageMessageFilter
   channel_->AddFilter(
       new DOMStorageMessageFilter(
           GetID(),
           storage_partition_impl_->GetDOMStorageContext()));
+
+  // IndexedDBDispatcherHost
   channel_->AddFilter(
       new IndexedDBDispatcherHost(
           GetID(),
           storage_partition_impl_->GetIndexedDBContext()));
+
+  // GeolocationDispatcherHost
   if (IsGuest()) {
     if (!g_browser_plugin_geolocation_context.Get()) {
       g_browser_plugin_geolocation_context.Get() =
           new BrowserPluginGeolocationPermissionContext();
     }
     channel_->AddFilter(GeolocationDispatcherHost::New(
         GetID(), g_browser_plugin_geolocation_context.Get()));
   } else {
     channel_->AddFilter(GeolocationDispatcherHost::New(
         GetID(), browser_context->GetGeolocationPermissionContext()));
   }
+
+  // GpuMessageFilter
   gpu_message_filter_ = new GpuMessageFilter(GetID(), widget_helper_.get());
   channel_->AddFilter(gpu_message_filter_);
+
 #if defined(ENABLE_WEBRTC)
+  // PeerConnectionTrackerHost
   peer_connection_tracker_host_ = new PeerConnectionTrackerHost(GetID());
   channel_->AddFilter(peer_connection_tracker_host_);
+
+  // MediaStreamDispatcherHost
   channel_->AddFilter(new MediaStreamDispatcherHost(GetID()));
 #endif
 #if defined(ENABLE_PLUGINS)
+  // PepperMessageFilter
   channel_->AddFilter(new PepperMessageFilter(GetID(), browser_context));
 #endif
 #if defined(ENABLE_INPUT_SPEECH)
+  // InputTagSpeechDispatcherHost and SpeechRecognitionDispatcherHost
   channel_->AddFilter(new InputTagSpeechDispatcherHost(
       IsGuest(), GetID(), storage_partition_impl_->GetURLRequestContext(),
       browser_context->GetSpeechRecognitionPreferences()));
   channel_->AddFilter(new SpeechRecognitionDispatcherHost(
       GetID(), storage_partition_impl_->GetURLRequestContext(),
       browser_context->GetSpeechRecognitionPreferences()));
 #endif
+
+  // FileAPIMessageFilter
   channel_->AddFilter(new FileAPIMessageFilter(
       GetID(),
       storage_partition_impl_->GetURLRequestContext(),
       storage_partition_impl_->GetFileSystemContext(),
       ChromeBlobStorageContext::GetFor(browser_context)));
+
+  // OrientationMessageFilter
   channel_->AddFilter(new OrientationMessageFilter());
+
+  // FileUtilitiesMessageFilter
   channel_->AddFilter(new FileUtilitiesMessageFilter(GetID()));
+
+  // MimeRegistryMessageFilter
   channel_->AddFilter(new MimeRegistryMessageFilter());
+
+  // DatabaseMessageFilter
   channel_->AddFilter(new DatabaseMessageFilter(
       storage_partition_impl_->GetDatabaseTracker()));
+
 #if defined(OS_MACOSX)
+  // TextInputClientMessageFilter
   channel_->AddFilter(new TextInputClientMessageFilter(GetID()));
 #elif defined(OS_WIN)
+  // FontCacheDispatcher
   channel_->AddFilter(new FontCacheDispatcher());
 #endif
 
+  // SocketStreamDispatcherHost
   SocketStreamDispatcherHost* socket_stream_dispatcher_host =
       new SocketStreamDispatcherHost(GetID(),
           new RendererURLRequestContextSelector(browser_context, GetID()),
           resource_context);
   channel_->AddFilter(socket_stream_dispatcher_host);
 
+  // WorkerMessageFilter
   channel_->AddFilter(
       new WorkerMessageFilter(
           GetID(),
           resource_context,
           WorkerStoragePartition(
               storage_partition_impl_->GetURLRequestContext(),
               storage_partition_impl_->GetMediaURLRequestContext(),
               storage_partition_impl_->GetAppCacheService(),
               storage_partition_impl_->GetQuotaManager(),
               storage_partition_impl_->GetFileSystemContext(),
               storage_partition_impl_->GetDatabaseTracker(),
               storage_partition_impl_->GetIndexedDBContext()),
           base::Bind(&RenderWidgetHelper::GetNextRoutingID,
                      base::Unretained(widget_helper_.get()))));
 
 #if defined(ENABLE_WEBRTC)
   channel_->AddFilter(new P2PSocketDispatcherHost(resource_context));
 #endif
 
+  // TraceMessageFilter
   channel_->AddFilter(new TraceMessageFilter());
+
+  // ResolveProxyMsgHelper
   channel_->AddFilter(new ResolveProxyMsgHelper(
       browser_context->GetRequestContextForRenderProcess(GetID())));
+
+  // QuotaDispatcherHost
   channel_->AddFilter(new QuotaDispatcherHost(
       GetID(),
       storage_partition_impl_->GetQuotaManager(),
       GetContentClient()->browser()->CreateQuotaPermissionContext()));
+
+  // QuotaDispatcherHost
   channel_->AddFilter(new GamepadBrowserMessageFilter());
+
+  // ProfilerMessageFilter
   channel_->AddFilter(new ProfilerMessageFilter(PROCESS_TYPE_RENDERER));
+
+  // HistogramMessageFilter
   channel_->AddFilter(new HistogramMessageFilter());
+
+  // HyphenatorMessageFilter
   channel_->AddFilter(new HyphenatorMessageFilter(this));
+
 #if defined(ENABLE_WEBRTC)
+  // WebRtcLoggingHandlerHost
   channel_->AddFilter(new WebRtcLoggingHandlerHost());
 #endif
+
+  channel_->AddFilter(new ExtensionSystemMessageFilter(this));
 }
 
 int RenderProcessHostImpl::GetNextRoutingID() {
   return widget_helper_->GetNextRoutingID();
 }
 
 void RenderProcessHostImpl::SimulateSwapOutACK(
     const ViewMsg_SwapOut_Params& params) {
   widget_helper_->SimulateSwapOutACK(params);
 }
@@ skipping 1033 matching lines @@
   TRACE_EVENT0("renderer_host",
                "RenderWidgetHostImpl::OnCompositorSurfaceBuffersSwappedNoHost");
   AcceleratedSurfaceMsg_BufferPresented_Params ack_params;
   ack_params.sync_point = 0;
   RenderWidgetHostImpl::AcknowledgeBufferPresent(route_id,
                                                  gpu_process_host_id,
                                                  ack_params);
 }
 
 }  // namespace content