Implementation of the "Redirect URLs to Packaged Apps" feature.

chrome/common/extensions/extension_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_set.h"
 
 #include "base/logging.h"
+#include "chrome/common/extensions/api/url_handlers/url_handlers_parser.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/manifest_handlers/sandboxed_page_info.h"
 #include "chrome/common/url_constants.h"
 #include "extensions/common/constants.h"
 
 using WebKit::WebSecurityOrigin;
 using extensions::Extension;
 
 ExtensionURLInfo::ExtensionURLInfo(WebSecurityOrigin origin, const GURL& url)
   : origin_(origin),
     url_(url) {
@@ skipping 98 matching lines @@
     const extensions::URLPatternSet& extent) const {
   for (ExtensionMap::const_iterator iter = extensions_.begin();
        iter != extensions_.end(); ++iter) {
     if (iter->second->web_extent().OverlapsWith(extent))
       return iter->second.get();
   }
 
   return NULL;
 }
 
+const extensions::UrlHandlerInfo*
+ExtensionSet::GetHandlingAppForURL(const GURL& url) const {

[not at google - send to devlin, 2013/08/19 23:32:24]

the name of this method and the thing it returns isn't consistent.

[sergeygs, 2013/08/29 08:24:42]

Done. This whole function has disappeared, replaced by a combination of new
static methods UrlHandlers and straightforward iteration over extensions at the
usage sites.

+  for (ExtensionMap::const_iterator extIt = extensions_.begin();
+       extIt != extensions_.end(); ++extIt) {

[not at google - send to devlin, 2013/08/19 23:32:24]

s/extIt/it/

[sergeygs, 2013/08/29 08:24:42]

Done.

+    if (extIt->second->is_app()) {

[not at google - send to devlin, 2013/08/19 23:32:24]

I don't really see the point in checking is_app here, since you're validating at
parse time that only packaged apps can have the manifest property in the first
place.

You can DCHECK(extension->is_platform_app()) if you really want (upon finding
the extension that handles it, if any). Makes sense.

[sergeygs, 2013/08/29 08:24:42]

Done.

+      const std::vector<extensions::UrlHandlerInfo>* handlers =
+          extensions::UrlHandlers::GetUrlHandlers(extIt->second);
+      if (handlers) {
+        for (std::vector<extensions::UrlHandlerInfo>::const_iterator handlerIt =

[not at google - send to devlin, 2013/08/19 23:32:24]

add a method to UrlHandlers that does this?

[sergeygs, 2013/08/29 08:24:42]

Done.

+              handlers->begin(); handlerIt != handlers->end(); handlerIt++) {
+          if (handlerIt->patterns.MatchesURL(url))
+            return &(*handlerIt);
+        }
+      }
+    }
+  }
+
+  return NULL;
+}
+
 bool ExtensionSet::InSameExtent(const GURL& old_url,
                                 const GURL& new_url) const {
   return GetExtensionOrAppByURL(ExtensionURLInfo(old_url)) ==
       GetExtensionOrAppByURL(ExtensionURLInfo(new_url));
 }
 
 const Extension* ExtensionSet::GetByID(const std::string& id) const {
   ExtensionMap::const_iterator i = extensions_.find(id);
   if (i != extensions_.end())
     return i->second.get();
@@ skipping 31 matching lines @@
 bool ExtensionSet::IsSandboxedPage(const ExtensionURLInfo& info) const {
   if (info.url().SchemeIs(extensions::kExtensionScheme)) {
     const Extension* extension = GetByID(info.url().host());
     if (extension) {
       return extensions::SandboxedPageInfo::IsSandboxedPage(extension,
                                                             info.url().path());
     }
   }
   return false;
 }