Implementation of the "Redirect URLs to Packaged Apps" feature.

chrome/browser/ui/browser_navigator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_navigator.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
@@ skipping 440 matching lines @@
 void Navigate(NavigateParams* params) {
   Browser* source_browser = params->browser;
   if (source_browser)
     params->initiating_profile = source_browser->profile();
   DCHECK(params->initiating_profile);
 
   if (!AdjustNavigateParamsForURL(params))
     return;
 
   ExtensionService* service = params->initiating_profile->GetExtensionService();
-  if (service)
+  if (service) {
+    // TODO(sergeygs): Shouldn't we return from here if this returns true?

[not at google - send to devlin, 2013/08/19 23:32:24]

no, it looks like this method modifies the URL to point to an error page.

[sergeygs, 2013/08/29 08:24:42]

Done.

     service->ShouldBlockUrlInBrowserTab(&params->url);
 
+    if (service->MaybeRedirectUrlToApp(params->url, params->referrer.url))
+      return;
+  }

[not at google - send to devlin, 2013/08/19 23:32:24]

when you pull the MaybeRedirecturlToApp logic out of ExtensionService, you could
make it an abstraction for platform app redirection. this could be like:

// would be nice to add an AppSystem and use that rather than ExtensionSystem.
extensions::PlatformAppRedirector* platform_app_redirector =
    extensions::ExtensionSystem::Get(params->initiating_profile)->
        platform_app_redirector();

if (platform_app_redirector->HandleUrl(params->url,
                                       params->referrer.url,
                                       &params->url))
  return;

[sergeygs, 2013/08/29 08:24:42]

Done. Would it make sense to also obtain the ExtensionService as
system->extension_service() now, for symmetry and minimizing local variables?

[not at google - send to devlin, 2013/08/29 17:35:56]

yeah that would be nice. You could restructure this part nicely:

ExtenisonSystem* system = ...;
if (system && !system->extension_service()->ShouldBlockUrlInBrowserTab()) {
  // ...
}

writing that snippet made me wonder whether we should only check the platform
app redirector if the extension service didn't rewrite the URL. It doesn't make
any sense for the platform app redirector to be handling error URLs.

[sergeygs, 2013/08/30 00:39:44]

Done. The second part didn't occur to me, but sounds like a reasonable idea.

+
   // The browser window may want to adjust the disposition.
   if (params->disposition == NEW_POPUP &&
       source_browser &&
       source_browser->window()) {
     params->disposition =
         source_browser->window()->GetDispositionForPopupBounds(
             params->window_bounds);
   }
 
   params->browser = GetBrowserForDisposition(params);
@@ skipping 183 matching lines @@
   bool reverse_on_redirect = false;
   content::BrowserURLHandler::GetInstance()->RewriteURLIfNecessary(
       &rewritten_url, browser_context, &reverse_on_redirect);
 
   // Some URLs are mapped to uber subpages. Do not allow them in incognito.
   return !(rewritten_url.scheme() == chrome::kChromeUIScheme &&
            rewritten_url.host() == chrome::kChromeUIUberHost);
 }
 
 }  // namespace chrome